New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lowercase letters in jar/version names #974

Closed
ryan-williams opened this Issue Mar 24, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Mar 24, 2016

I sometimes build ADAM assembly JARs with the abbreviated git sha as the maven version; currently adam-{shell,submit} check for JARs with only numbers and uppercase letters, so they miss these.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Mar 24, 2016

Member

Fixed via 34f6dc2

Member

heuermh commented Mar 24, 2016

Fixed via 34f6dc2

@heuermh heuermh closed this Mar 24, 2016

@heuermh heuermh reopened this Mar 24, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Mar 24, 2016

Member

Sorry for reopening this, I remembered a reason why a-z wasn't allowed, it pulls in the -javadoc jar

$ ./bin/adam-submit vcf2adam adam-core/src/test/resources/small.vcf small.adam
Found multiple ADAM cli assembly jars in /Users/xxx/working/adam/adam-cli/target:
adam-cli_2.10-0.19.1-SNAPSHOT-javadoc.jar
adam-cli_2.10-0.19.1-SNAPSHOT.jar
Please remove all but one jar.
Member

heuermh commented Mar 24, 2016

Sorry for reopening this, I remembered a reason why a-z wasn't allowed, it pulls in the -javadoc jar

$ ./bin/adam-submit vcf2adam adam-core/src/test/resources/small.vcf small.adam
Found multiple ADAM cli assembly jars in /Users/xxx/working/adam/adam-cli/target:
adam-cli_2.10-0.19.1-SNAPSHOT-javadoc.jar
adam-cli_2.10-0.19.1-SNAPSHOT.jar
Please remove all but one jar.
@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Mar 24, 2016

Member

hrm that's annoying. my versions only use a-f so we could very hackily rely on the j and o in -javadoc.jar but that doesn't sound great.

should we encode our assumptions about jar basenames more explicity? e.g. rather than just the glob we do now, do some post-processing on the globbed paths to pull out the assembly jar. I can write something to do that if you like.

Member

ryan-williams commented Mar 24, 2016

hrm that's annoying. my versions only use a-f so we could very hackily rely on the j and o in -javadoc.jar but that doesn't sound great.

should we encode our assumptions about jar basenames more explicity? e.g. rather than just the glob we do now, do some post-processing on the globbed paths to pull out the assembly jar. I can write something to do that if you like.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Mar 24, 2016

Member

I remember at one point there was a ^[-javadoc] in the regex. :)

Have at a new method to find the assembly jar; I don't like the current one. The only interesting requirement is that the assembly jar is found in repo when running from a binary distribution and adam-cli/target when built from source.

Member

heuermh commented Mar 24, 2016

I remember at one point there was a ^[-javadoc] in the regex. :)

Have at a new method to find the assembly jar; I don't like the current one. The only interesting requirement is that the assembly jar is found in repo when running from a binary distribution and adam-cli/target when built from source.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 21, 2016

Member

Resolved by 4955aee.

Member

fnothaft commented Apr 21, 2016

Resolved by 4955aee.

@fnothaft fnothaft closed this Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment