New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1004] Remove recursive maven.build.timestamp declaration #1005

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@heuermh
Member

heuermh commented Apr 20, 2016

Fixes #1004

This workaround for https://issues.apache.org/jira/browse/MRESOURCES-99 hasn't always worked for me in the past, but it seems to work fine here

$ ./bin/adam-submit --version
Using ADAM_MAIN=org.bdgenomics.adam.cli.ADAMMain
Using SPARK_SUBMIT=/usr/local/bin/spark-submit

       e         888~-_          e             e    e
      d8b        888   \        d8b           d8b  d8b
     /Y88b       888    |      /Y88b         d888bdY88b
    /  Y88b      888    |     /  Y88b       / Y88Y Y888b
   /____Y88b     888   /     /____Y88b     /   YY   Y888b
  /      Y88b    888_-~     /      Y88b   /          Y888b

ADAM version: 0.19.1-SNAPSHOT
Commit: f8c3133ae75947fde0a29d63f025f81fbcdb58f9 Build: 2016-04-20
Built for: Scala 2.10 and Hadoop 2.6.0
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 20, 2016

Member

LGTM! As an aside, how has the workaround broke for you in the past? If it's not obvious, can we document on #1004 so that we have a note to our future selves?

Member

fnothaft commented Apr 20, 2016

LGTM! As an aside, how has the workaround broke for you in the past? If it's not obvious, can we document on #1004 so that we have a note to our future selves?

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 20, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1158/
Test PASSed.

AmplabJenkins commented Apr 20, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1158/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Apr 20, 2016

Member

The template variable wouldn't be replaced in the About class, so you'd get this

$ ./bin/adam-submit --version
Using ADAM_MAIN=org.bdgenomics.adam.cli.ADAMMain
Using SPARK_SUBMIT=/usr/local/bin/spark-submit

       e         888~-_          e             e    e
      d8b        888   \        d8b           d8b  d8b
     /Y88b       888    |      /Y88b         d888bdY88b
    /  Y88b      888    |     /  Y88b       / Y88Y Y888b
   /____Y88b     888   /     /____Y88b     /   YY   Y888b
  /      Y88b    888_-~     /      Y88b   /          Y888b

ADAM version: 0.19.1-SNAPSHOT
Commit: f8c3133ae75947fde0a29d63f025f81fbcdb58f9 Build: ${timestamp}
Built for: Scala 2.10 and Hadoop 2.6.0
Member

heuermh commented Apr 20, 2016

The template variable wouldn't be replaced in the About class, so you'd get this

$ ./bin/adam-submit --version
Using ADAM_MAIN=org.bdgenomics.adam.cli.ADAMMain
Using SPARK_SUBMIT=/usr/local/bin/spark-submit

       e         888~-_          e             e    e
      d8b        888   \        d8b           d8b  d8b
     /Y88b       888    |      /Y88b         d888bdY88b
    /  Y88b      888    |     /  Y88b       / Y88Y Y888b
   /____Y88b     888   /     /____Y88b     /   YY   Y888b
  /      Y88b    888_-~     /      Y88b   /          Y888b

ADAM version: 0.19.1-SNAPSHOT
Commit: f8c3133ae75947fde0a29d63f025f81fbcdb58f9 Build: ${timestamp}
Built for: Scala 2.10 and Hadoop 2.6.0

@heuermh heuermh changed the title from Remove recursive maven.build.timestamp declaration to [ADAM-1004] Remove recursive maven.build.timestamp declaration Apr 21, 2016

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 28, 2016

Member

Thanks @heuermh! Merged as 6b28217.

Member

fnothaft commented Apr 28, 2016

Thanks @heuermh! Merged as 6b28217.

@fnothaft fnothaft closed this Apr 28, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Apr 29, 2016

Member

Thanks!

Member

heuermh commented Apr 29, 2016

Thanks!

@heuermh heuermh deleted the heuermh:issue-1004 branch Apr 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment