[ADAM-602] Remove plugin code. #1065

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Jul 4, 2016

Resolves #602:

  • Removed the org.bdgenomics.adam.plugins package.
  • Removed the PluginExecutor command.
  • Removed the JavaADAMPlugin from the Java API.

Not so much a documentation update, but org.bdgenomics.adam.plugins was next on my documentation push, and I thought we had a ticket to remove it. CC @heuermh @tdanford because I can't remember if we had a consensus RE: removing plugins or not.

[ADAM-602] Remove plugin code.
Resolves #602:

* Removed the `org.bdgenomics.adam.plugins` package.
* Removed the `PluginExecutor` command.
* Removed the `JavaADAMPlugin` from the Java API.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 4, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1296/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1296/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 4, 2016

Member

Some relevant discussion issue in #602. I'm still +1 to the general idea.

Member

heuermh commented Jul 4, 2016

Some relevant discussion issue in #602. I'm still +1 to the general idea.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 6, 2016

Member

Merged commit e545d1a

Thank you, @fnothaft!

Member

heuermh commented Jul 6, 2016

Merged commit e545d1a

Thank you, @fnothaft!

@heuermh heuermh closed this Jul 6, 2016

heuermh added a commit to heuermh/adam-plugins that referenced this pull request Jul 6, 2016

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Jul 7, 2016

Contributor

Retroactive +1.

Contributor

tdanford commented Jul 7, 2016

Retroactive +1.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 7, 2016

Member

Thanks, @tdanford! Sorry about being overly productive today :)

Member

heuermh commented Jul 7, 2016

Thanks, @tdanford! Sorry about being overly productive today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment