[ADAM-1039] Add basic support for Sample record. #1077

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Jul 7, 2016

Resolves #1039.

Arguably, a bit of work to do.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 7, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1322/

Build result: FAILURE

GitHub pull request #1077 of commit a981d39 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1077/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains a30c661490c18049c80471e48f4be1c0965f0fe9 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1077/merge^{commit} # timeout=10Checking out Revision a30c661490c18049c80471e48f4be1c0965f0fe9 (origin/pr/1077/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f a30c661490c18049c80471e48f4be1c0965f0fe9First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1322/

Build result: FAILURE

GitHub pull request #1077 of commit a981d39 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1077/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains a30c661490c18049c80471e48f4be1c0965f0fe9 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1077/merge^{commit} # timeout=10Checking out Revision a30c661490c18049c80471e48f4be1c0965f0fe9 (origin/pr/1077/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f a30c661490c18049c80471e48f4be1c0965f0fe9First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 7, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1323/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1323/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 18, 2016

Member

LGTM

@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

Member

heuermh commented Jul 18, 2016

LGTM

@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

@heuermh heuermh modified the milestone: 0.20.0 Jul 18, 2016

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 19, 2016

Member

Rebased!

Member

fnothaft commented Jul 19, 2016

Rebased!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 19, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1351/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1351/
Test PASSed.

@jpdna

This comment has been minimized.

Show comment
Hide comment
@jpdna

jpdna Jul 19, 2016

Member

@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

Yes - LGTM

Member

jpdna commented Jul 19, 2016

@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

Yes - LGTM

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 19, 2016

Member

Merged commit 4b6e107.

Thank you, @fnothaft!

Member

heuermh commented Jul 19, 2016

Merged commit 4b6e107.

Thank you, @fnothaft!

@heuermh heuermh closed this Jul 19, 2016

@fnothaft fnothaft deleted the fnothaft:issues/1039-sample branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment