[ADAM-1087] Migrate away from FileSystem.get #1116

Merged
merged 1 commit into from Aug 27, 2016

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Aug 14, 2016

FileSystem.get returns the configured default file system. This can cause issues when loading a file off a non-default FileSystem, e.g., an NFS or S3. This PR changes to use Path.getFileSystem. Resolves #1087.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 14, 2016

Member

I am -1ing this until I verify it on the cluster.

Member

fnothaft commented Aug 14, 2016

I am -1ing this until I verify it on the cluster.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 14, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1387/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1387/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 16, 2016

Member

LGTM. Yes, it would be good to verify on the cluster.

Member

heuermh commented Aug 16, 2016

LGTM. Yes, it would be good to verify on the cluster.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 26, 2016

Member

+1, as this is working a-OK on the cluster. I will rebase on the latest changes, and then I think we're good for a merge.

Member

fnothaft commented Aug 26, 2016

+1, as this is working a-OK on the cluster. I will rebase on the latest changes, and then I think we're good for a merge.

[ADAM-1087] Migrate away from FileSystem.get
FileSystem.get returns the configured default file system. This can cause
issues when loading a file off a non-default FileSystem, e.g., an NFS or S3.
This PR changes to use Path.getFileSystem. Resolves #1087.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 26, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1431/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1431/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 27, 2016

Member

Ping for merge.

Member

fnothaft commented Aug 27, 2016

Ping for merge.

@heuermh heuermh merged commit 4140095 into bigdatagenomics:master Aug 27, 2016

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 27, 2016

Member

Merged as commit 4140095.

Thank you, @fnothaft!

Member

heuermh commented Aug 27, 2016

Merged as commit 4140095.

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment