Update for bdg-formats code style changes #1126

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
4 participants
@heuermh
Member

heuermh commented Aug 24, 2016

No description provided.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 24, 2016

Member

LGTM! Can you resolve the conflicts?

Member

fnothaft commented Aug 24, 2016

LGTM! Can you resolve the conflicts?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2016

Member

Don't see why there would be any.

Member

heuermh commented Aug 24, 2016

Don't see why there would be any.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 24, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1414/

Build result: FAILURE

GitHub pull request #1126 of commit 43bd039.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse 43bd039^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 43bd039 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1126/head^{commit} # timeout=10Checking out Revision 43bd039 (origin/pr/1126/head) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 43bd039b3b86d08e15e378e1335b72a0fb40ae14First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1414/

Build result: FAILURE

GitHub pull request #1126 of commit 43bd039.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse 43bd039^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 43bd039 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1126/head^{commit} # timeout=10Checking out Revision 43bd039 (origin/pr/1126/head) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 43bd039b3b86d08e15e378e1335b72a0fb40ae14First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2016

Member

Oh wait, there's a commit on the feature branch I didn't see before, d86f258. That won't work since bdg-formats HEAD builds as 0.9.1-SNAPSHOT.

Member

heuermh commented Aug 24, 2016

Oh wait, there's a commit on the feature branch I didn't see before, d86f258. That won't work since bdg-formats HEAD builds as 0.9.1-SNAPSHOT.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2016

Member

GIt can't seem to infer what I want to do when I use commands incorrectly

$ git rebase -i upstream/upgrade-to-bdg-formats-0.10.0
fatal: Needed a single revision
invalid upstream upstream/upgrade-to-bdg-formats-0.10.0
Member

heuermh commented Aug 24, 2016

GIt can't seem to infer what I want to do when I use commands incorrectly

$ git rebase -i upstream/upgrade-to-bdg-formats-0.10.0
fatal: Needed a single revision
invalid upstream upstream/upgrade-to-bdg-formats-0.10.0
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2016

Member

That means I'm git stuck. 😦 Please advise.

Member

heuermh commented Aug 24, 2016

That means I'm git stuck. 😦 Please advise.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 24, 2016

Member

Did you do git fetch upstream? What happens if you do git checkout upstream/upgrade-to-bdg-formats-0.10.0?

Member

fnothaft commented Aug 24, 2016

Did you do git fetch upstream? What happens if you do git checkout upstream/upgrade-to-bdg-formats-0.10.0?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2016

Member

Nope. Not realizing there were any commits on upgrade-to-bdg-formats-0.10.0 I branched from master.

Member

heuermh commented Aug 24, 2016

Nope. Not realizing there were any commits on upgrade-to-bdg-formats-0.10.0 I branched from master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 24, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1417/

Build result: FAILURE

GitHub pull request #1126 of commit bf886c9 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1126/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains fb78db3 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1126/merge^{commit} # timeout=10Checking out Revision fb78db3 (origin/pr/1126/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f fb78db388ecbe43062fc423cab713ebf46296adeFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1417/

Build result: FAILURE

GitHub pull request #1126 of commit bf886c9 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1126/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains fb78db3 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1126/merge^{commit} # timeout=10Checking out Revision fb78db3 (origin/pr/1126/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f fb78db388ecbe43062fc423cab713ebf46296adeFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 25, 2016

Member

Jenkins isn't getting the latest bdg-formats snapshot build. Do I have to mvn deploy a snapshot manually or is Jenkins supposed to be taking care of that automatically?

Member

heuermh commented Aug 25, 2016

Jenkins isn't getting the latest bdg-formats snapshot build. Do I have to mvn deploy a snapshot manually or is Jenkins supposed to be taking care of that automatically?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 25, 2016

Member

Jenkins isn't getting the latest bdg-formats snapshot build. Do I have to mvn deploy a snapshot manually or is Jenkins supposed to be taking care of that automatically?

Jenkins did get the latest bdg-formats snapshot. However! What Jenkins did not do, was build and deploy the snapshot after the last bdg-formats commit was pushed. There was an issue with the refspec for the bdg-formats master branch that caused the git polling hook to fail. The polling hook should run in 10 minutes; I'll trigger this build once Jenkins has pushed the bdg-formats snapshot.

Member

fnothaft commented Aug 25, 2016

Jenkins isn't getting the latest bdg-formats snapshot build. Do I have to mvn deploy a snapshot manually or is Jenkins supposed to be taking care of that automatically?

Jenkins did get the latest bdg-formats snapshot. However! What Jenkins did not do, was build and deploy the snapshot after the last bdg-formats commit was pushed. There was an issue with the refspec for the bdg-formats master branch that caused the git polling hook to fail. The polling hook should run in 10 minutes; I'll trigger this build once Jenkins has pushed the bdg-formats snapshot.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 25, 2016

Member

Jenkins, test this please.

Member

fnothaft commented Aug 25, 2016

Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 25, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1418/

Build result: FAILURE

[...truncated 24 lines...]Triggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.5.2,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.5.2,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1418/

Build result: FAILURE

[...truncated 24 lines...]Triggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.5.2,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.5.2,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 25, 2016

Member

Thanks. I'm not sure how to interpret the latest build matrix -- only some of the Jenkins build configurations got the right snapshot version?

Member

heuermh commented Aug 25, 2016

Thanks. I'm not sure how to interpret the latest build matrix -- only some of the Jenkins build configurations got the right snapshot version?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 25, 2016

Member

Jenkins, retest this please.

Member

heuermh commented Aug 25, 2016

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 25, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1419/

Build result: FAILURE

[...truncated 24 lines...]Triggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.5.2,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.5.2,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1419/

Build result: FAILURE

[...truncated 24 lines...]Triggering ADAM-prb ? 2.3.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.3.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.3.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.5.2,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.4.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.3.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.5.2,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.4.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 25, 2016

Member

Jenkins, test this please.

Member

heuermh commented Aug 25, 2016

Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 25, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1423/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1423/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 25, 2016

Member

Woot!

Member

heuermh commented Aug 25, 2016

Woot!

@jpdna

This comment has been minimized.

Show comment
Hide comment
@jpdna

jpdna Aug 26, 2016

Member

LGTM - is this ready to merge?

Member

jpdna commented Aug 26, 2016

LGTM - is this ready to merge?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 26, 2016

Member

LGTM

Member

fnothaft commented Aug 26, 2016

LGTM

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 26, 2016

Member

is this ready to merge?

Yes, please

Member

heuermh commented Aug 26, 2016

is this ready to merge?

Yes, please

@fnothaft fnothaft merged commit 65adcf6 into bigdatagenomics:upgrade-to-bdg-formats-0.10.0 Aug 26, 2016

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 26, 2016

Member

Thanks @heuermh! For these PRs against the topic branch, I'm just going to use the green merge button, since we'll eventually need to sort out the topic branch itself.

Member

fnothaft commented Aug 26, 2016

Thanks @heuermh! For these PRs against the topic branch, I'm just going to use the green merge button, since we'll eventually need to sort out the topic branch itself.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 26, 2016

Member

Thanks!

Member

heuermh commented Aug 26, 2016

Thanks!

@heuermh heuermh deleted the heuermh:formats-issue-100 branch Aug 26, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 26, 2016

Member

As far as topic branching goes, should I be merging commits from master here or will we resolve all of those when merging the topic branch?

Member

heuermh commented Aug 26, 2016

As far as topic branching goes, should I be merging commits from master here or will we resolve all of those when merging the topic branch?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 26, 2016

Member

I'm thinking that we should periodically rebase the 0.10.0 branch on master. To make it easier to tell when we've got a merge conflict, perhaps we should PR 0.10.0 against master? This way, we'll get a CI build whenever we push an update, and GitHub will tell us whenever we're out of date.

Member

fnothaft commented Aug 26, 2016

I'm thinking that we should periodically rebase the 0.10.0 branch on master. To make it easier to tell when we've got a merge conflict, perhaps we should PR 0.10.0 against master? This way, we'll get a CI build whenever we push an update, and GitHub will tell us whenever we're out of date.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 26, 2016

Member

Opened #1135.

Member

fnothaft commented Aug 26, 2016

Opened #1135.

heuermh added a commit to heuermh/adam that referenced this pull request Sep 27, 2016

fnothaft added a commit that referenced this pull request Nov 15, 2016

Bump to bdg-formats 0.10.0.
* Update for bdg-formats code style changes (#1126)
* Remove StructuralVariant and StructuralVariantType, add names field to Variant
* Merge VariantAnnotation and DatabaseVariantAnnotation records
* Implement separate variant and genotype filters; rename VariantContext.databases field

fnothaft added a commit that referenced this pull request Nov 15, 2016

Bump to bdg-formats 0.10.0.
* Update for bdg-formats code style changes (#1126)
* Remove StructuralVariant and StructuralVariantType, add names field to Variant
* Merge VariantAnnotation and DatabaseVariantAnnotation records
* Implement separate variant and genotype filters; rename VariantContext.databases field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment