Reorder kryo.register statements in ADAMKryoRegistrator #1148

Merged
merged 1 commit into from Sep 6, 2016

Conversation

Projects
None yet
3 participants
@heuermh
Member

heuermh commented Sep 2, 2016

Fixes #1146

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 2, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1454/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1454/
Test PASSed.

+ kryo.register(classOf[org.bdgenomics.adam.models.NonoverlappingRegions])
+ kryo.register(classOf[org.bdgenomics.adam.models.RecordGroup])
+ kryo.register(classOf[org.bdgenomics.adam.models.RecordGroupDictionary])
+ kryo.register(classOf[org.bdgenomics.adam.models.ReferencePosition], new org.bdgenomics.adam.models.ReferencePositionSerializer)

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

+ kryo.register(classOf[org.bdgenomics.adam.models.RecordGroupDictionary])
+ kryo.register(classOf[org.bdgenomics.adam.models.ReferencePosition], new org.bdgenomics.adam.models.ReferencePositionSerializer)
+ kryo.register(classOf[org.bdgenomics.adam.models.ReferenceRegion])
+ kryo.register(classOf[org.bdgenomics.adam.models.ReferencePositionPair], new org.bdgenomics.adam.models.ReferencePositionPairSerializer)

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

+ kryo.register(classOf[org.bdgenomics.adam.models.SAMFileHeaderWritable])
+ kryo.register(classOf[org.bdgenomics.adam.models.SequenceDictionary])
+ kryo.register(classOf[org.bdgenomics.adam.models.SequenceRecord])
+ kryo.register(classOf[org.bdgenomics.adam.models.SingleReadBucket], new org.bdgenomics.adam.models.SingleReadBucketSerializer)

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

+ kryo.register(classOf[org.bdgenomics.adam.rdd.read.DuplicateMetrics])
+
+ // org.bdgenomics.adam.rdd.read.realignment
+ kryo.register(classOf[org.bdgenomics.adam.rdd.read.realignment.IndelRealignmentTarget], new org.bdgenomics.adam.rdd.read.realignment.IndelRealignmentTargetSerializer)

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines for the following 3

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines for the following 3

+ kryo.register(classOf[org.bdgenomics.adam.util.MdTag])
+ kryo.register(classOf[org.bdgenomics.adam.util.QualityScore])
+ kryo.register(classOf[org.bdgenomics.adam.util.ReferenceContigMap])
+ kryo.register(classOf[org.bdgenomics.adam.util.TwoBitFile], new org.bdgenomics.adam.util.TwoBitFileSerializer)

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines

+ kryo.register(classOf[org.bdgenomics.adam.util.TwoBitFile], new org.bdgenomics.adam.util.TwoBitFileSerializer)
+
+ // org.bdgenomics.formats.avro
+ kryo.register(classOf[org.bdgenomics.formats.avro.AlignmentRecord], new AvroSerializer[org.bdgenomics.formats.avro.AlignmentRecord])

This comment has been minimized.

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines for all these lines

@fnothaft

fnothaft Sep 3, 2016

Member

Nit: break long lines for all these lines

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 3, 2016

Member

LGTM! Dropped a few nits about long lines. What do you think about pulling the AvroSerializer bits out into their own files?

Member

fnothaft commented Sep 3, 2016

LGTM! Dropped a few nits about long lines. What do you think about pulling the AvroSerializer bits out into their own files?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 5, 2016

Member

Dude, get a wider monitor! ;)

Member

heuermh commented Sep 5, 2016

Dude, get a wider monitor! ;)

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 5, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1455/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1455/
Test PASSed.

@fnothaft fnothaft merged commit 9a18d53 into bigdatagenomics:master Sep 6, 2016

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 6, 2016

Member

Merged. Thanks @heuermh!

Member

fnothaft commented Sep 6, 2016

Merged. Thanks @heuermh!

@heuermh heuermh deleted the heuermh:reorder-kryo branch Sep 6, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 6, 2016

Member

Thank you!

Member

heuermh commented Sep 6, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment