New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1188] Delete scripts/commit-pr.sh #1189

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Sep 30, 2016

Resolves #1188.

@heuermh

Wanted to note some dissenting opinion in this Hacker News thread
https://news.ycombinator.com/item?id=12581710

I'm still +1

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 30, 2016

Member

Thanks for the link @heuermh ! @hannes-ucsc and I were just discussing the CI point on the Toil scrum. I think that as long as they block unsafe rebases, the result is equivalent.

Member

fnothaft commented Sep 30, 2016

Thanks for the link @heuermh ! @hannes-ucsc and I were just discussing the CI point on the Toil scrum. I think that as long as they block unsafe rebases, the result is equivalent.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 30, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1511/
Test PASSed.

AmplabJenkins commented Sep 30, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1511/
Test PASSed.

@heuermh heuermh merged commit dadfe1c into bigdatagenomics:master Oct 3, 2016

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 3, 2016

Member

Thank you, @fnothaft!

Member

heuermh commented Oct 3, 2016

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment