Fastq record converter #1208

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Oct 13, 2016

Moving @zyxue's work over from #1185, but squashed down and with @heuermh's review comments in.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 13, 2016

Member

I will squash and merge on tests passing.

Member

fnothaft commented Oct 13, 2016

I will squash and merge on tests passing.

@fnothaft fnothaft referenced this pull request Oct 13, 2016

Closed

Fastq record converter #1185

@zyxue

This comment has been minimized.

Show comment
Hide comment
@zyxue

zyxue Oct 13, 2016

Contributor

@heuermh has added some more requests on #1185, I haven't got a chance to look into it yet. Will do later.

Contributor

zyxue commented Oct 13, 2016

@heuermh has added some more requests on #1185, I haven't got a chance to look into it yet. Will do later.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 13, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1534/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1534/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 13, 2016

Member

Hi @zyxue! We're trying to get a release of ADAM out tomorrow, and we wanted to get your work on #1185 in to that release, so I added a commit here to address @heuermh's comments. Thanks again for all your hard work on the code!

Member

fnothaft commented Oct 13, 2016

Hi @zyxue! We're trying to get a release of ADAM out tomorrow, and we wanted to get your work on #1185 in to that release, so I added a commit here to address @heuermh's comments. Thanks again for all your hard work on the code!

@zyxue

This comment has been minimized.

Show comment
Hide comment
@zyxue

zyxue Oct 13, 2016

Contributor

I see, I can try to incorporate them tonight (Pacific time). I think @heuermh has some good comment that's worth looking into. You can run a test later, if that's not too late?

Contributor

zyxue commented Oct 13, 2016

I see, I can try to incorporate them tonight (Pacific time). I think @heuermh has some good comment that's worth looking into. You can run a test later, if that's not too late?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 13, 2016

Member

Squashed and merged as df00eff. Thanks @zyxue for the contribution!

Member

fnothaft commented Oct 13, 2016

Squashed and merged as df00eff. Thanks @zyxue for the contribution!

@fnothaft fnothaft closed this Oct 13, 2016

@fnothaft fnothaft deleted the zyxue-FastqRecordConverter branch Oct 13, 2016

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 13, 2016

Member

I see, I can try to incorporate them tonight (Pacific time). I think @heuermh has some good comment that's worth looking into. You can run a test later, if that's not too late?

Not to worry! I was able to address @heuermh's comments here (and test them as well) real quick. Thanks again for the contribution; we appreciate you taking the time to contribute the code and are glad that you were able to patch up this issue for us!

Member

fnothaft commented Oct 13, 2016

I see, I can try to incorporate them tonight (Pacific time). I think @heuermh has some good comment that's worth looking into. You can run a test later, if that's not too late?

Not to worry! I was able to address @heuermh's comments here (and test them as well) real quick. Thanks again for the contribution; we appreciate you taking the time to contribute the code and are glad that you were able to patch up this issue for us!

@zyxue

This comment has been minimized.

Show comment
Hide comment
@zyxue

zyxue Oct 13, 2016

Contributor

OK, Thanks! ADAM is a good project! I am glad that I can contribute.

Contributor

zyxue commented Oct 13, 2016

OK, Thanks! ADAM is a good project! I am glad that I can contribute.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 14, 2016

Member

@zyxue thank you for your contribution, and thank you for your patience through the process, sometimes Jenkins can be a bit flaky.

Member

heuermh commented Oct 14, 2016

@zyxue thank you for your contribution, and thank you for your patience through the process, sometimes Jenkins can be a bit flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment