Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing uses of deprecated class SAMFileReader #1235

Closed

Conversation

@lbergelson
Copy link
Contributor

lbergelson commented Nov 2, 2016

Replacing all references to SAMFileReader, this is a long deprecated htsjdk class that's been replaced by SamReader.

this is necessary to be compatible with htsjdk 2.7.0+
@AmplabJenkins
Copy link

AmplabJenkins commented Nov 2, 2016

Can one of the admins verify this patch?

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

Awesome, thanks @lbergelson! I will take a look at this later today.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

Jenkins, test this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 2, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1552/
Test PASSed.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

This looks good to me, but there's a couple of small style nits (mostly import ordering stuff, we're picky). I'll clean those up. Thanks for making the upgrade pass @lbergelson!

@lbergelson
Copy link
Contributor Author

lbergelson commented Nov 2, 2016

Ah, sorry about the import stuff. My IDE did some automatic import shuffling I think.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

Ah, sorry about the import stuff. My IDE did some automatic import shuffling I think.

Oh, no worries! It's a pretty small bit of cleanup.

@lbergelson
Copy link
Contributor Author

lbergelson commented Nov 2, 2016

I can do a quick fix up of them if you'd like, or if it's easier I'll leave it to you.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

I can do a quick fix up of them if you'd like, or if it's easier I'll leave it to you.

No sweat; I've got it 75% done already.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2016

I've cleaned up the little import nits in #1236. Thank you @lbergelson for the patches!

@fnothaft fnothaft closed this Nov 2, 2016
@lbergelson lbergelson deleted the lbergelson:lb_remove_SAMFileRader branch Nov 2, 2016
@lbergelson
Copy link
Contributor Author

lbergelson commented Nov 2, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.