New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1242] Clean up dead code in org.bdgenomics.adam.util. #1243

Merged
merged 3 commits into from Nov 7, 2016

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Nov 5, 2016

Resolves #1242. Removed:

  • org.bdgenomics.adam.util.ImplicitJavaConversions
  • org.bdgenomics.adam.util.IntervalListReader
  • org.bdgenomics.adam.util.MapTools
  • org.bdgenomics.adam.util.RegExp
  • org.bdgenomics.adam.util.Util
[ADAM-1242] Clean up dead code in org.bdgenomics.adam.util.
Resolves #1242. Removed:

* org.bdgenomics.adam.util.ImplicitJavaConversions
* org.bdgenomics.adam.util.IntervalListReader
* org.bdgenomics.adam.util.MapTools
* org.bdgenomics.adam.util.RegExp
* org.bdgenomics.adam.util.Util
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 5, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1556/
Test PASSed.

AmplabJenkins commented Nov 5, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1556/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 6, 2016

Member

I've added two commits:

  • 694dbe2 does a general documentation cleanup
  • f148b07 moves several classes/objects to different packages, and tightens up protections on these classes

This is good to go from my side.

Member

fnothaft commented Nov 6, 2016

I've added two commits:

  • 694dbe2 does a general documentation cleanup
  • f148b07 moves several classes/objects to different packages, and tightens up protections on these classes

This is good to go from my side.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 6, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1557/
Test PASSed.

AmplabJenkins commented Nov 6, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1557/
Test PASSed.

Show outdated Hide outdated adam-core/src/main/scala/org/bdgenomics/adam/util/ReferenceContigMap.scala
case class ReferenceContigMap(contigMap: Map[String, Seq[NucleotideContigFragment]]) extends ReferenceFile {
// create sequence dictionary
/**
* The sequence dictionary corresponding to the contigs in this two bit file.

This comment has been minimized.

@heuermh

heuermh Nov 7, 2016

Member

this isn't a two bit file

@heuermh

heuermh Nov 7, 2016

Member

this isn't a two bit file

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 7, 2016

Member

Looks great other than one doc fix

Member

heuermh commented Nov 7, 2016

Looks great other than one doc fix

fnothaft added some commits Nov 6, 2016

Several package moves, as part of the `org.bdgenomics.adam.util` clea…
…nup:

* Moved `NormalizationUtils` to `org.bdgenomics.adam.algorithms.consensus`, and
  made it package private to `consensus`.
* Moved `MdTag` to `org.bdgenomics.adam.models`.
* Moved `QualityScore` to `org.bdgenomics.adam.models` and made it package
  private to `consensus`.
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 7, 2016

Member

Fixed the documentation issue and pushed.

Member

fnothaft commented Nov 7, 2016

Fixed the documentation issue and pushed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 7, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1561/
Test PASSed.

AmplabJenkins commented Nov 7, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1561/
Test PASSed.

@heuermh

heuermh approved these changes Nov 7, 2016

@heuermh heuermh merged commit 266e2fc into bigdatagenomics:master Nov 7, 2016

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 7, 2016

Member

Thanks, @fnothaft!

Member

heuermh commented Nov 7, 2016

Thanks, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment