Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous VCF fixes #1247

Merged
merged 4 commits into from Nov 8, 2016
Merged

Conversation

@fnothaft
Copy link
Member

fnothaft commented Nov 7, 2016

Fixes #1202, #1226, #1232, supersedes #1205.

var sort: Boolean = false

@Args4jOption(required = false,
name = "-sort_lexicographically_on_save",
usage = "Sort the VCF output by lexicographic order. Conflicts with -sort_on_save.")

This comment has been minimized.

Copy link
@heuermh

heuermh Nov 7, 2016

Member

Is there any possibility of a third sort method? If so, maybe separate -sort_on_save and -sort_by [method] arguments would be preferrable

This comment has been minimized.

Copy link
@fnothaft

fnothaft Nov 7, 2016

Author Member

I can't think of one...

* @param asSingleFile If true, saves the output as a single file by merging
* the sharded output after completing the write to HDFS. If false, the
* output of this call will be written as shards, where each shard has a
* valid VCF header. Default is false.
*/
def saveAsVcf(filePath: String,

This comment has been minimized.

Copy link
@heuermh

heuermh Nov 7, 2016

Member

too many boolean parameters here

This comment has been minimized.

Copy link
@fnothaft

fnothaft Nov 7, 2016

Author Member

I kinda agree. I think it would probably make sense to break this out as is done with AlignmentRecords and have sortByXYZ functions.

This comment has been minimized.

Copy link
@heuermh
@AmplabJenkins
Copy link

AmplabJenkins commented Nov 7, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1560/
Test PASSed.

jpdna and others added 4 commits Oct 11, 2016
Resolves #1226. Adds logic to
`org.bdgenomics.adam.converters.VariantContextConverter` that checks for a
4 element array in the `strandBiasComponents` field. If this is present, this
is exported as the "SB" VCF field.
Resolves #1232. Adds ability to select between lexicographic and contig index
sort order when saving a sorted VCF file.
@fnothaft fnothaft force-pushed the fnothaft:issues/1232-vcf-fixes branch from f593f7b to ffbbf39 Nov 8, 2016
@AmplabJenkins
Copy link

AmplabJenkins commented Nov 8, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1562/
Test PASSed.

@heuermh
heuermh approved these changes Nov 8, 2016
@heuermh heuermh merged commit 480c23e into bigdatagenomics:master Nov 8, 2016
1 check passed
1 check passed
default Merged build finished.
Details
@heuermh
Copy link
Member

heuermh commented Nov 8, 2016

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.