[ADAM-1196] Add support for open ReferenceRegions. #1252

Merged
merged 1 commit into from Nov 10, 2016

Conversation

Projects
3 participants
@fnothaft
Member

fnothaft commented Nov 8, 2016

Resolves #1196.

@fnothaft fnothaft added this to the 0.21.0 milestone Nov 8, 2016

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 8, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1569/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1569/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 8, 2016

Member

LGTM, is this really all that is necessary?

Member

heuermh commented Nov 8, 2016

LGTM, is this really all that is necessary?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 8, 2016

Member

I think so, but ideally @ryan-williams can comment. It looks like the code he referenced earlier in Guacamole disappeared, so I'm not 100% sure what he was thinking the interface would look like.

Member

fnothaft commented Nov 8, 2016

I think so, but ideally @ryan-williams can comment. It looks like the code he referenced earlier in Guacamole disappeared, so I'm not 100% sure what he was thinking the interface would look like.

@heuermh heuermh merged commit 748b952 into bigdatagenomics:master Nov 10, 2016

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 10, 2016

Member

Thank you, @fnothaft!

Member

heuermh commented Nov 10, 2016

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment