some style nits #1278

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@ryan-williams
Member

ryan-williams commented Nov 17, 2016

basically just cleared up the intellij warnings in two files I was working in for #1277:

  • unused imports
  • many no-op else records branches of RDD-instrumenting-if-statements
  • some .size->.length changes
  • some unnecessary .toSeqs
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 17, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1621/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1621/
Test PASSed.

@@ -480,7 +472,10 @@ class ADAMContext private (@transient val sc: SparkContext) extends Serializable
sc.newAPIHadoopFile(filePath, classOf[AnySAMInputFormat], classOf[LongWritable],
classOf[SAMRecordWritable], ContextUtil.getConfiguration(job))
}
- if (Metrics.isRecording) records.instrument() else records
+
+ if (Metrics.isRecording)

This comment has been minimized.

@heuermh

heuermh Nov 20, 2016

Member

Though I'll probably get downvoted, I prefer to always have curly braces

if (Metrics.isRecording) {
  records.instrument()
}
@heuermh

heuermh Nov 20, 2016

Member

Though I'll probably get downvoted, I prefer to always have curly braces

if (Metrics.isRecording) {
  records.instrument()
}

This comment has been minimized.

@fnothaft

fnothaft Nov 20, 2016

Member

I'm also an "always braces" type.

@fnothaft

fnothaft Nov 20, 2016

Member

I'm also an "always braces" type.

@heuermh heuermh referenced this pull request Dec 2, 2016

Merged

Code style fixes #1299

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Dec 15, 2016

Member

Would it be ok to close this without merging?

Member

heuermh commented Dec 15, 2016

Would it be ok to close this without merging?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 15, 2016

Member

@heueh +1

Member

fnothaft commented Dec 15, 2016

@heueh +1

@heuermh heuermh closed this Dec 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment