Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some style nits #1278

Closed
wants to merge 2 commits into from
Closed

some style nits #1278

wants to merge 2 commits into from

Conversation

@ryan-williams
Copy link
Member

ryan-williams commented Nov 17, 2016

basically just cleared up the intellij warnings in two files I was working in for #1277:

  • unused imports
  • many no-op else records branches of RDD-instrumenting-if-statements
  • some .size->.length changes
  • some unnecessary .toSeqs
@AmplabJenkins
Copy link

AmplabJenkins commented Nov 17, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1621/
Test PASSed.

@@ -480,7 +472,10 @@ class ADAMContext private (@transient val sc: SparkContext) extends Serializable
sc.newAPIHadoopFile(filePath, classOf[AnySAMInputFormat], classOf[LongWritable],
classOf[SAMRecordWritable], ContextUtil.getConfiguration(job))
}
if (Metrics.isRecording) records.instrument() else records

if (Metrics.isRecording)

This comment has been minimized.

Copy link
@heuermh

heuermh Nov 20, 2016

Member

Though I'll probably get downvoted, I prefer to always have curly braces

if (Metrics.isRecording) {
  records.instrument()
}

This comment has been minimized.

Copy link
@fnothaft

fnothaft Nov 20, 2016

Member

I'm also an "always braces" type.

@heuermh heuermh mentioned this pull request Dec 2, 2016
@heuermh
Copy link
Member

heuermh commented Dec 15, 2016

Would it be ok to close this without merging?

@fnothaft
Copy link
Member

fnothaft commented Dec 15, 2016

@heueh +1

@heuermh heuermh closed this Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.