Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ADAMContext and JavaADAMContext constructors public #1298

Merged
merged 1 commit into from Dec 7, 2016

Conversation

@heuermh
Copy link
Member

@heuermh heuermh commented Dec 2, 2016

import org.bdgenomics.adam.rdd.ADAMContext._
import org.bdgenomics.adam.util.ADAMFunSuite
import org.bdgenomics.formats.avro.AlignmentRecord

class JavaADAMContextSuite extends ADAMFunSuite {

sparkTest("ctr is accessible") {

This comment has been minimized.

@ryan-williams

ryan-williams Dec 2, 2016
Member

I'm -ε on this as a test

This comment has been minimized.

@heuermh

heuermh Dec 2, 2016
Author Member

I agree, but if we change visibility again, at least something will fail here instead of in a downstream project.

This comment has been minimized.

@fnothaft

fnothaft Dec 7, 2016
Member

Nice!

@ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Dec 2, 2016

lgtm

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Dec 2, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1655/
Test PASSed.

@heuermh heuermh mentioned this pull request Dec 5, 2016
@fnothaft fnothaft merged commit 3a6734f into bigdatagenomics:master Dec 7, 2016
1 check passed
1 check passed
default Merged build finished.
Details
@fnothaft
Copy link
Member

@fnothaft fnothaft commented Dec 7, 2016

Merged! Thanks @heuermh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.