Make ADAMContext and JavaADAMContext constructors public #1298

Merged
merged 1 commit into from Dec 7, 2016

Conversation

Projects
None yet
4 participants
import org.bdgenomics.adam.rdd.ADAMContext._
import org.bdgenomics.adam.util.ADAMFunSuite
import org.bdgenomics.formats.avro.AlignmentRecord
class JavaADAMContextSuite extends ADAMFunSuite {
+ sparkTest("ctr is accessible") {

This comment has been minimized.

@ryan-williams

ryan-williams Dec 2, 2016

Member

I'm -ε on this as a test

@ryan-williams

ryan-williams Dec 2, 2016

Member

I'm -ε on this as a test

This comment has been minimized.

@heuermh

heuermh Dec 2, 2016

Member

I agree, but if we change visibility again, at least something will fail here instead of in a downstream project.

@heuermh

heuermh Dec 2, 2016

Member

I agree, but if we change visibility again, at least something will fail here instead of in a downstream project.

This comment has been minimized.

@fnothaft

fnothaft Dec 7, 2016

Member

Nice!

@fnothaft

fnothaft Dec 7, 2016

Member

Nice!

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
Member

ryan-williams commented Dec 2, 2016

lgtm

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 2, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1655/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1655/
Test PASSed.

@heuermh heuermh referenced this pull request Dec 5, 2016

Merged

Code style fixes #1299

@fnothaft fnothaft merged commit 3a6734f into bigdatagenomics:master Dec 7, 2016

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 7, 2016

Member

Merged! Thanks @heuermh!

Member

fnothaft commented Dec 7, 2016

Merged! Thanks @heuermh!

@heuermh heuermh deleted the heuermh:public-context-ctr branch Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment