New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deduping fragments #1309

Merged
merged 2 commits into from Jan 19, 2017

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Dec 10, 2016

Resolves #1302 and #1303. Needs more tests and a Pandoc update. Also, I'm thinking the reads2fragments and fragments2reads CLIs should be merged down to a transformFragments CLI. Any disagreement?

@fnothaft fnothaft added this to the 0.21.1 milestone Dec 10, 2016

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 10, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1677/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1677/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Dec 13, 2016

Member

I'm thinking the reads2fragments and fragments2reads CLIs should be merged down to a transformFragments CLI.

+1

Member

heuermh commented Dec 13, 2016

I'm thinking the reads2fragments and fragments2reads CLIs should be merged down to a transformFragments CLI.

+1

val bamFiles = getFsAndFiles(path)
val filteredFiles = bamFiles.filter(p => {
val pPath = p.getName()
pPath.endsWith(".bam") || pPath.endsWith(".cram") ||

This comment has been minimized.

@heuermh

heuermh Dec 13, 2016

Member

could split this out into a separate method similar to isVcfExt

@heuermh

heuermh Dec 13, 2016

Member

could split this out into a separate method similar to isVcfExt

This comment has been minimized.

* @return A new RDD where reads have the duplicate read flag set. Duplicate
* reads are NOT filtered out.
*/
def markDuplicates(): FragmentRDD = MarkDuplicatesInDriver.time {

This comment has been minimized.

@heuermh

heuermh Dec 13, 2016

Member

is this saying that MarkDuplicates runs solely on the driver, or that the timer is?

@heuermh

heuermh Dec 13, 2016

Member

is this saying that MarkDuplicates runs solely on the driver, or that the timer is?

This comment has been minimized.

@fnothaft

fnothaft Dec 13, 2016

Member

Just the timer.

@fnothaft

fnothaft Dec 13, 2016

Member

Just the timer.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 19, 2017

Member

Rebased. Tests and documentation are good to go now too.

Member

fnothaft commented Jan 19, 2017

Rebased. Tests and documentation are good to go now too.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 19, 2017

Member

I.e., this PR is good to merge.

Member

fnothaft commented Jan 19, 2017

I.e., this PR is good to merge.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1744/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1744/
Test PASSed.

@heuermh heuermh merged commit 01297b6 into bigdatagenomics:master Jan 19, 2017

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 19, 2017

Member

Thank you, @fnothaft!

Member

heuermh commented Jan 19, 2017

Thank you, @fnothaft!

@fnothaft fnothaft deleted the fnothaft:issues/1302-1303-fragment-mkdups branch May 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment