clean up *Join type-params/scaldocs #1325

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Dec 23, 2016

  • using : ClassTag in the type-param declarations is cleaner than passing implicit evidence params
  • some of the scaladocs about type-params were invalid / duplicated in wrong places
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 23, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1705/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1705/
Test PASSed.

@fnothaft

LGTM! Thanks @ryan-williams!

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 24, 2016

Member

Thanks @ryan-williams! I've squashed down 1509448 and 41f5552 to 9ff0fa5 and kept 2e3211f (which is now defb611) and merged manually.

Member

fnothaft commented Dec 24, 2016

Thanks @ryan-williams! I've squashed down 1509448 and 41f5552 to 9ff0fa5 and kept 2e3211f (which is now defb611) and merged manually.

@fnothaft fnothaft closed this Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment