Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up *Join type-params/scaldocs #1325

Closed
wants to merge 3 commits into from

Conversation

@ryan-williams
Copy link
Member

ryan-williams commented Dec 23, 2016

  • using : ClassTag in the type-param declarations is cleaner than passing implicit evidence params
  • some of the scaladocs about type-params were invalid / duplicated in wrong places
@AmplabJenkins
Copy link

AmplabJenkins commented Dec 23, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1705/
Test PASSed.

Copy link
Member

fnothaft left a comment

LGTM! Thanks @ryan-williams!

@fnothaft
Copy link
Member

fnothaft commented Dec 24, 2016

Thanks @ryan-williams! I've squashed down 1509448 and 41f5552 to 9ff0fa5 and kept 2e3211f (which is now defb611) and merged manually.

@fnothaft fnothaft closed this Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.