Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1307] move_to_spark_2 fails after moving to scala 2.11. #1329

Merged
merged 1 commit into from Dec 27, 2016

Conversation

@fnothaft
Copy link
Member

fnothaft commented Dec 27, 2016

The sed command that moved to Spark 2 looked for _2.10 in the ADAM pom artifact names. This commit fixes that issue by looking for _2.1 instead, which matches both Scala 2.10 and 2.11, as well as the eventual Scala 2.12. Resolves #1307.

The sed command that moved to Spark 2 looked for _2.10 in the
ADAM pom artifact names. This commit fixes that issue by looking
for _2.1 instead, which matches both Scala 2.10 and 2.11, as well
as the eventual Scala 2.12. Resolves #1307.
@fnothaft fnothaft requested a review from heuermh Dec 27, 2016
@AmplabJenkins
Copy link

AmplabJenkins commented Dec 27, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1708/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Dec 27, 2016

Thanks, this works for me.

We might want to restrict the 2.10/2.11 replace patterns (later is probably fine) as we're accidentally causing this

$ git diff .
diff --git a/pom.xml b/pom.xml
index 73976347..a69f47a0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -475,7 +475,7 @@
       </dependency>
       <dependency>
         <groupId>org.apache.parquet</groupId>
-        <!-- This library has no Scala 2.11 version, but using the 2.10 version seems to work. -->
+        <!-- This library has no Scala 2.10 version, but using the 2.10 version seems to work. -->
         <artifactId>parquet-scala_2.10</artifactId>
         <version>${parquet.version}</version>
         <exclusions>

and with utils currently at version 0.2.10 and json4s at version 3.2.11 we might run into other trouble.

@fnothaft
Copy link
Member Author

fnothaft commented Dec 27, 2016

We might want to restrict the 2.10/2.11 replace patterns (later is probably fine) as we're accidentally causing this

IIRC, I fix that in #1319

@heuermh heuermh merged commit d272738 into bigdatagenomics:master Dec 27, 2016
1 check passed
1 check passed
default Merged build finished.
Details
@heuermh
Copy link
Member

heuermh commented Dec 27, 2016

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.