Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1337] Remove os.{flush,close} calls after writing VCF header. #1338

Merged

Conversation

@fnothaft
Copy link
Member

fnothaft commented Jan 3, 2017

Resolves #1337. The VCF writer calls close on the underlying stream.

Resolves #1337. The VCF writer calls close on the underlying stream.
@fnothaft fnothaft added this to the 0.21.0 milestone Jan 3, 2017
@AmplabJenkins
Copy link

AmplabJenkins commented Jan 3, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1716/
Test PASSed.

@heuermh
heuermh approved these changes Jan 3, 2017
@heuermh heuermh merged commit 1e9aa31 into bigdatagenomics:master Jan 4, 2017
1 check passed
1 check passed
default Merged build finished.
Details
@heuermh
Copy link
Member

heuermh commented Jan 4, 2017

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.