New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make javac see that AlignmentRecordRDD extends GenomicRDD #1386

Merged
merged 2 commits into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Feb 8, 2017

Resolves #1092. Prior to this, javac would not recognize the AlignmentRecordRDD trait as extending GenomicRDD. Done in two commits, as I'd like to pick the commit that makes AlignmentRecordRDD concrete over to 0.21.1, but I'd rather not delete the (Un)AlignedReadRDD classes on 0.21.1.

fnothaft added some commits Feb 8, 2017

[ADAM-1092] AlignmentRecordRDD should be an abstract class.
Resolves #1092. Prior to this, javac would not recognize the AlignmentRecordRDD
trait as extending GenomicRDD.

@fnothaft fnothaft added this to the 0.21.1 milestone Feb 8, 2017

@heuermh

heuermh approved these changes Feb 8, 2017

I like it! Will test downstream once Jenkins weighs in.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 8, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1779/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1779/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Feb 8, 2017

Member

Works for me downstream, thanks!

Member

heuermh commented Feb 8, 2017

Works for me downstream, thanks!

@heuermh heuermh merged commit 5ae8820 into bigdatagenomics:master Feb 8, 2017

1 check passed

default Merged build finished.
Details

@fnothaft fnothaft referenced this pull request Feb 10, 2017

Closed

WIP Python API #1387

3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment