Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make javac see that AlignmentRecordRDD extends GenomicRDD #1386

Merged
merged 2 commits into from Feb 8, 2017

Conversation

@fnothaft
Copy link
Member

fnothaft commented Feb 8, 2017

Resolves #1092. Prior to this, javac would not recognize the AlignmentRecordRDD trait as extending GenomicRDD. Done in two commits, as I'd like to pick the commit that makes AlignmentRecordRDD concrete over to 0.21.1, but I'd rather not delete the (Un)AlignedReadRDD classes on 0.21.1.

fnothaft added 2 commits Feb 8, 2017
Resolves #1092. Prior to this, javac would not recognize the AlignmentRecordRDD
trait as extending GenomicRDD.
@fnothaft fnothaft added this to the 0.21.1 milestone Feb 8, 2017
@heuermh
heuermh approved these changes Feb 8, 2017
Copy link
Member

heuermh left a comment

I like it! Will test downstream once Jenkins weighs in.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 8, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1779/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Feb 8, 2017

Works for me downstream, thanks!

@heuermh heuermh merged commit 5ae8820 into bigdatagenomics:master Feb 8, 2017
1 check passed
1 check passed
default Merged build finished.
Details
@fnothaft fnothaft mentioned this pull request Feb 10, 2017
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.