Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1393] fix missing reads when transforming fastq to adam #1394

Merged
merged 1 commit into from Feb 21, 2017

Conversation

@A-Tsai
Copy link
Contributor

A-Tsai commented Feb 17, 2017

To fix #1393, don't double count the length of the readname line. In addition, to prevent the length of a line is longer than MAX_LINE_LENGTH in https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/java/org/bdgenomics/adam/io/FastqRecordReader.java#L330

… the length of the readname line
@AmplabJenkins
Copy link

AmplabJenkins commented Feb 17, 2017

Can one of the admins verify this patch?

@heuermh
Copy link
Member

heuermh commented Feb 17, 2017

@A-Tsai thank you for the help on this issue!

@heuermh
Copy link
Member

heuermh commented Feb 17, 2017

Jenkins, test this please

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 17, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1805/
Test PASSed.

Copy link
Member

fnothaft left a comment

Thanks @A-Tsai! I will leave this open until next week for others to review, but it looks great from my side. We greatly appreciate you contributing a fix!

@heuermh heuermh changed the title fix missing reads when transforming fastq to adam [ADAM-1393] fix missing reads when transforming fastq to adam Feb 21, 2017
@heuermh heuermh merged commit 0e57357 into bigdatagenomics:master Feb 21, 2017
1 check passed
1 check passed
default Merged build finished.
Details
@heuermh
Copy link
Member

heuermh commented Feb 21, 2017

Thank you, @A-Tsai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.