Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added JavaApi for loadCoverage #1437

Merged
merged 1 commit into from Mar 15, 2017
Merged

Conversation

@akmorrow13
Copy link
Contributor

akmorrow13 commented Mar 14, 2017

Resolves #1420

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage decreased (-0.05%) to 76.611% when pulling edfe707 on akmorrow13:javaApi into b8477dc on bigdatagenomics:master.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 14, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1867/

Build result: FAILURE

[...truncated 16 lines...] > /home/jenkins/git2/bin/git rev-parse origin/pr/1437/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 722171a62e5d70e7037012970dcc600a1ed5550d # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1437/merge^{commit} # timeout=10Checking out Revision 722171a62e5d70e7037012970dcc600a1ed5550d (origin/pr/1437/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 722171a62e5d70e7037012970dcc600a1ed5550dFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft
Copy link
Member

fnothaft commented Mar 14, 2017

Jenkins, retest this please.

@akmorrow13
Copy link
Contributor Author

akmorrow13 commented Mar 14, 2017

Adding tests.

@akmorrow13 akmorrow13 force-pushed the akmorrow13:javaApi branch from edfe707 to 824acd3 Mar 14, 2017
@akmorrow13
Copy link
Contributor Author

akmorrow13 commented Mar 14, 2017

Jenkins, retest this please.

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage decreased (-0.03%) to 76.628% when pulling 824acd3 on akmorrow13:javaApi into b8477dc on bigdatagenomics:master.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1870/
Test PASSed.

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage decreased (-0.03%) to 76.628% when pulling 824acd3 on akmorrow13:javaApi into b8477dc on bigdatagenomics:master.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1871/
Test PASSed.

@@ -84,6 +84,16 @@ class JavaADAMContext(val ac: ADAMContext) extends Serializable {
}

/**
* Loads in a coverage file. This method can load BED, NARROWPEAK, and ADAM files.

This comment has been minimized.

Copy link
@heuermh

heuermh Mar 14, 2017

Member

NARROWPEAK → NarrowPeak as used elsewhere

What about the other feature formats (i.e. GFF3, GTF/GFF2, and IntervalList) supported by loadFeatures?

@akmorrow13 akmorrow13 force-pushed the akmorrow13:javaApi branch from 824acd3 to 83e64b1 Mar 14, 2017
@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.07%) to 76.628% when pulling 83e64b1 on akmorrow13:javaApi into 9938d3c on bigdatagenomics:master.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1876/
Test PASSed.

@heuermh heuermh merged commit cf39e6c into bigdatagenomics:master Mar 15, 2017
2 checks passed
2 checks passed
coverage/coveralls Coverage increased (+0.07%) to 76.628%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

heuermh commented Mar 15, 2017

Thank you, @akmorrow13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.