New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding require for Coverage Conversion and related tests #1472

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
5 participants
@devin-petersohn
Member

devin-petersohn commented Apr 4, 2017

Resolves #1471

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling f6e726f on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

coveralls commented Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling f6e726f on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1927/
Test PASSed.

AmplabJenkins commented Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1927/
Test PASSed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling 7a6d8d9 on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

coveralls commented Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling 7a6d8d9 on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1928/
Test PASSed.

AmplabJenkins commented Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1928/
Test PASSed.

Adding require for Coverage Conversion and related tests
Addressing reviewer comments

Addressing reviewer comments
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling 690f948 on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

coveralls commented Apr 4, 2017

Coverage Status

Coverage increased (+0.002%) to 81.535% when pulling 690f948 on devin-petersohn:issue#1471nullpointer into b26b851 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1929/
Test PASSed.

AmplabJenkins commented Apr 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1929/
Test PASSed.

@fnothaft fnothaft merged commit 98d2c92 into bigdatagenomics:master Apr 4, 2017

2 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage increased (+0.002%) to 81.535%
Details
default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 4, 2017

Member

Merged! Thanks @devin-petersohn!

Member

fnothaft commented Apr 4, 2017

Merged! Thanks @devin-petersohn!

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment