New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1476] Treat `.` ALT allele as symbolic non-ref. #1477

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
5 participants
@fnothaft
Member

fnothaft commented Apr 6, 2017

Resolves #1476.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 6, 2017

Coverage Status

Coverage increased (+0.1%) to 81.637% when pulling b20dce2 on fnothaft:issues/1476-drop-.-alts into 9505d47 on bigdatagenomics:master.

coveralls commented Apr 6, 2017

Coverage Status

Coverage increased (+0.1%) to 81.637% when pulling b20dce2 on fnothaft:issues/1476-drop-.-alts into 9505d47 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 6, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1935/
Test PASSed.

AmplabJenkins commented Apr 6, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1935/
Test PASSed.

@@ -182,31 +182,37 @@ class ADAMContextSuite extends ADAMFunSuite {
sparkTest("can read a gzipped .vcf file") {
val path = testFile("test.vcf.gz")
val vcs = sc.loadVcf(path)
assert(vcs.rdd.count === 6)
assert(vcs.rdd.count === 7)

This comment has been minimized.

@heuermh

heuermh Apr 6, 2017

Member

were the compressed test resources changed too?

@heuermh

heuermh Apr 6, 2017

Member

were the compressed test resources changed too?

This comment has been minimized.

@fnothaft

fnothaft Apr 6, 2017

Member

Nope... they appear to have been a compressed version of the VCF file from Hadoop-BAM.

@fnothaft

fnothaft Apr 6, 2017

Member

Nope... they appear to have been a compressed version of the VCF file from Hadoop-BAM.

This comment has been minimized.

@heuermh

heuermh Apr 6, 2017

Member

:facepalm:

@heuermh

heuermh Apr 6, 2017

Member

:facepalm:

@heuermh

heuermh approved these changes Apr 6, 2017

@heuermh heuermh merged commit 93b32c6 into bigdatagenomics:master Apr 7, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage increased (+0.1%) to 81.637%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Apr 7, 2017

Member

Thank you, @fnothaft!

Member

heuermh commented Apr 7, 2017

Thank you, @fnothaft!

@a1xt06

This comment has been minimized.

Show comment
Hide comment
@a1xt06

a1xt06 Apr 7, 2017

Thank you!

a1xt06 commented Apr 7, 2017

Thank you!

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment