New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1377] Adding fragment InFormatter for Bowtie tab6 format #1491

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
4 participants
@heuermh
Member

heuermh commented Apr 14, 2017

Fixes #1377. Work in progress, need to write tests and eliminate copy-pasta.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 14, 2017

Coverage Status

Coverage decreased (-0.4%) to 81.344% when pulling 54adbc0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

coveralls commented Apr 14, 2017

Coverage Status

Coverage decreased (-0.4%) to 81.344% when pulling 54adbc0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 14, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.459% when pulling 54adbc0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

coveralls commented Apr 14, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.459% when pulling 54adbc0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1950/
Test PASSed.

AmplabJenkins commented Apr 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1950/
Test PASSed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 17, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.44% when pulling 65a5b61 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

coveralls commented Apr 17, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.44% when pulling 65a5b61 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 17, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1952/
Test PASSed.

AmplabJenkins commented Apr 17, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1952/
Test PASSed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 19, 2017

Coverage Status

Coverage increased (+0.3%) to 82.003% when pulling 48b9ce0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

coveralls commented Apr 19, 2017

Coverage Status

Coverage increased (+0.3%) to 82.003% when pulling 48b9ce0 on heuermh:alt-tab56 into 04444aa on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1956/
Test PASSed.

AmplabJenkins commented Apr 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1956/
Test PASSed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 24, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.709% when pulling f687d1e on heuermh:alt-tab56 into 5b6a109 on bigdatagenomics:master.

coveralls commented Apr 24, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.709% when pulling f687d1e on heuermh:alt-tab56 into 5b6a109 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1961/
Test PASSed.

AmplabJenkins commented Apr 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1961/
Test PASSed.

@fnothaft

LGTM! @heuermh is this ready for merge from your end?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Apr 25, 2017

Member

Yes, thank you.

Member

heuermh commented Apr 25, 2017

Yes, thank you.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 25, 2017

Member

Thanks! Any chance you could squash the 1st and 3rd commits down? If not, I will merge manually later.

Member

fnothaft commented Apr 25, 2017

Thanks! Any chance you could squash the 1st and 3rd commits down? If not, I will merge manually later.

@heuermh heuermh added this to the 0.23.0 milestone Apr 25, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 25, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.709% when pulling 5f9c874 on heuermh:alt-tab56 into 5b6a109 on bigdatagenomics:master.

coveralls commented Apr 25, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.709% when pulling 5f9c874 on heuermh:alt-tab56 into 5b6a109 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 25, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1963/
Test PASSed.

AmplabJenkins commented Apr 25, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1963/
Test PASSed.

@fnothaft fnothaft merged commit dbe5c97 into bigdatagenomics:master Apr 25, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 81.709%
Details
codacy/pr Good work! A positive pull request.
Details
default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 25, 2017

Member

Merged! Thanks @heuermh!

Member

fnothaft commented Apr 25, 2017

Merged! Thanks @heuermh!

@heuermh heuermh deleted the heuermh:alt-tab56 branch Apr 25, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment