Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1483] Remove collapse parameter from AlignmentRecordRDD.toCoverage #1493

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 17, 2017

Resolves #1483. Instead of providing a parameter in the toCoverage method to allow users to collapse the coverage, makes the toCoverage method stupid. This makes the toCoverage method simpler and the behavior easier to reason about.

@fnothaft fnothaft added this to the 0.23.0 milestone Apr 17, 2017
@fnothaft fnothaft requested a review from akmorrow13 Apr 17, 2017
@coveralls
Copy link

@coveralls coveralls commented Apr 17, 2017

Coverage Status

Coverage decreased (-0.05%) to 81.668% when pulling 82c982e on fnothaft:issues/1483-reads-coverage-collapse into 04444aa on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Apr 17, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1951/
Test PASSed.

@heuermh
Copy link
Member

@heuermh heuermh commented May 3, 2017

Ping @akmorrow13 for review

Resolves #1483. Instead of providing a parameter in the `toCoverage` method to
allow users to collapse the coverage, makes the `toCoverage` method stupid. This
makes the `toCoverage` method simpler and the behavior easier to reason about.
@fnothaft fnothaft force-pushed the fnothaft:issues/1483-reads-coverage-collapse branch from 82c982e to 04c5764 May 10, 2017
@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented May 10, 2017

@heuermh Rebased.

@coveralls
Copy link

@coveralls coveralls commented May 10, 2017

Coverage Status

Coverage increased (+0.09%) to 81.873% when pulling 04c5764 on fnothaft:issues/1483-reads-coverage-collapse into 4eea07c on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 10, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1981/
Test PASSed.

@heuermh heuermh merged commit ea9ce6c into bigdatagenomics:master May 10, 2017
2 of 3 checks passed
2 of 3 checks passed
codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage increased (+0.09%) to 81.873%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented May 10, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.