Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1502] Preserve contig ordering in TwoBitFile sequence dictionary. #1508

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 29, 2017

Resolves #1502.

@tomwhite this should resolve the issue you were seeing. Can you test this out on your end?

@fnothaft fnothaft requested a review from tomwhite Apr 29, 2017
@fnothaft fnothaft added this to the 0.23.0 milestone Apr 29, 2017
@coveralls
Copy link

@coveralls coveralls commented Apr 29, 2017

Coverage Status

Coverage increased (+0.07%) to 81.783% when pulling c017ebc on fnothaft:issues/1502-twobit-sequence-order into dbe5c97 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Apr 29, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1968/
Test PASSed.

fnothaft added a commit to fnothaft/adam that referenced this pull request Apr 29, 2017
@heuermh
heuermh approved these changes May 3, 2017
@tomwhite
Copy link
Member

@tomwhite tomwhite commented May 5, 2017

I haven't got a straightforward way of testing this at the moment, but this looks good to me.

Thanks for the fix @fnothaft.

@heuermh heuermh merged commit 36d8e0b into bigdatagenomics:master May 5, 2017
2 of 3 checks passed
2 of 3 checks passed
codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage increased (+0.07%) to 81.783%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented May 5, 2017

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.