Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1486] Respect validation stringency if BAM header load fails. #1525

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented May 12, 2017

Resolves #1486.

@fnothaft fnothaft requested review from ryan-williams and heuermh May 12, 2017
@fnothaft fnothaft assigned fnothaft and unassigned fnothaft May 12, 2017
@fnothaft fnothaft added this to the 0.23.0 milestone May 12, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 12, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1998/

Build result: FAILURE

[...truncated 16 lines...] > /home/jenkins/git2/bin/git rev-parse origin/pr/1525/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains b24b42ea4e2bb964cc9bc2467d27c04766d88a6d # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1525/merge^{commit} # timeout=10Checking out Revision b24b42ea4e2bb964cc9bc2467d27c04766d88a6d (origin/pr/1525/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f b24b42ea4e2bb964cc9bc2467d27c04766d88a6dFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft fnothaft force-pushed the fnothaft:issues/1486-bam-header-load-error branch from bbc8638 to 94e8bd6 May 12, 2017
@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented May 12, 2017

Helps to include the new test file...

@coveralls
Copy link

@coveralls coveralls commented May 12, 2017

Coverage Status

Coverage remained the same at 82.015% when pulling 94e8bd6 on fnothaft:issues/1486-bam-header-load-error into 18191f9 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 12, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2000/
Test PASSed.

@heuermh heuermh merged commit 7fc5b4f into bigdatagenomics:master May 16, 2017
2 of 3 checks passed
2 of 3 checks passed
codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage remained the same at 82.015%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented May 16, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.