New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1169] Write GFF header line pragma in single file mode. #1529

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
4 participants
@fnothaft
Member

fnothaft commented May 15, 2017

Resolves #1169.

@fnothaft fnothaft added this to the 0.23.0 milestone May 15, 2017

@fnothaft fnothaft requested a review from heuermh May 15, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 15, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.754% when pulling 3197212 on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

coveralls commented May 15, 2017

Coverage Status

Coverage decreased (-0.3%) to 81.754% when pulling 3197212 on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 81.93% when pulling 3197212 on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

coveralls commented May 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 81.93% when pulling 3197212 on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 15, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2011/
Test PASSed.

AmplabJenkins commented May 15, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2011/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft May 15, 2017

Member

@heuermh addressed comments.

Member

fnothaft commented May 15, 2017

@heuermh addressed comments.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 15, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2012/

Build result: FAILURE

[...truncated 16 lines...] > /home/jenkins/git2/bin/git rev-parse origin/pr/1529/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9a # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1529/merge^{commit} # timeout=10Checking out Revision 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9a (origin/pr/1529/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

AmplabJenkins commented May 15, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2012/

Build result: FAILURE

[...truncated 16 lines...] > /home/jenkins/git2/bin/git rev-parse origin/pr/1529/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9a # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1529/merge^{commit} # timeout=10Checking out Revision 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9a (origin/pr/1529/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 3fe7fe43c4e94f4646dbe923d04f7950a15a7b9aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 81.93% when pulling a13ff4a on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

coveralls commented May 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 81.93% when pulling a13ff4a on fnothaft:issues/1169-gff-pragma into 18191f9 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 15, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2013/
Test PASSed.

AmplabJenkins commented May 15, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2013/
Test PASSed.

@heuermh heuermh merged commit e8f9bed into bigdatagenomics:master May 16, 2017

1 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage decreased (-0.08%) to 81.93%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh May 16, 2017

Member

Thank you, @fnothaft!

Member

heuermh commented May 16, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment