New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple unit test to SingleFastqInputFormat #1541

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
4 participants
@kkaneda
Contributor

kkaneda commented May 20, 2017

Hi,

I was randomly reading the code and decided to add a simple test. I didn't go further since I wasn't sure this is something actually useful.

Could you please take a look? Thanks!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 20, 2017

Can one of the admins verify this patch?

AmplabJenkins commented May 20, 2017

Can one of the admins verify this patch?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh May 20, 2017

Member

Jenkins, test this please

Member

heuermh commented May 20, 2017

Jenkins, test this please

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 20, 2017

Coverage Status

Coverage decreased (-0.1%) to 81.867% when pulling 7725de4 on kkaneda:kaneda/fast_unittest into fe1cba2 on bigdatagenomics:master.

coveralls commented May 20, 2017

Coverage Status

Coverage decreased (-0.1%) to 81.867% when pulling 7725de4 on kkaneda:kaneda/fast_unittest into fe1cba2 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 20, 2017

Coverage Status

Coverage remained the same at 81.993% when pulling 7725de4 on kkaneda:kaneda/fast_unittest into fe1cba2 on bigdatagenomics:master.

coveralls commented May 20, 2017

Coverage Status

Coverage remained the same at 81.993% when pulling 7725de4 on kkaneda:kaneda/fast_unittest into fe1cba2 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 20, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2028/
Test PASSed.

AmplabJenkins commented May 20, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2028/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh May 20, 2017

Member

Even though SingleFastqInputFormat is written in java, the rest of our unit test code is in scala. Would it be possible to port this to scala using ScalaTest? We use the FunSuite style, which reads very similar to JUnit.

The source file will also need a license header, which is located in the repo at https://github.com/bigdatagenomics/adam/blob/master/LICENSE_header.txt.

Member

heuermh commented May 20, 2017

Even though SingleFastqInputFormat is written in java, the rest of our unit test code is in scala. Would it be possible to port this to scala using ScalaTest? We use the FunSuite style, which reads very similar to JUnit.

The source file will also need a license header, which is located in the repo at https://github.com/bigdatagenomics/adam/blob/master/LICENSE_header.txt.

@kkaneda

This comment has been minimized.

Show comment
Hide comment
@kkaneda

kkaneda May 21, 2017

Contributor

Thanks for taking a look, @heuermh ! Ah, didn't notice that.

So, we have SingleFastqInputFormatSuite, and it seems that has sufficient coverage. I'll decline the PR.

Contributor

kkaneda commented May 21, 2017

Thanks for taking a look, @heuermh ! Ah, didn't notice that.

So, we have SingleFastqInputFormatSuite, and it seems that has sufficient coverage. I'll decline the PR.

@kkaneda kkaneda closed this May 21, 2017

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment