Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-941] Automatically generate projection enums. #1547

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented May 24, 2017

Resolves #941. Depends on #1391.

@fnothaft fnothaft added this to the 0.23.0 milestone May 24, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 24, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2054/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1547/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains a002d7d264042d9fd03d04375e537f2138a89482 # timeout=10Checking out Revision a002d7d264042d9fd03d04375e537f2138a89482 (origin/pr/1547/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f a002d7d264042d9fd03d04375e537f2138a89482First time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh
Copy link
Member

@heuermh heuermh commented May 24, 2017

This is pretty sweet :)

@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from 9d460cf to b163e14 May 24, 2017
@coveralls
Copy link

@coveralls coveralls commented May 24, 2017

Coverage Status

Coverage decreased (-3.6%) to 78.45% when pulling b163e14 on fnothaft:issues/941-autogen-projection-enums into 2820e94 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2055/
Test PASSed.

@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from b163e14 to cec9560 Jun 22, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jun 22, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2119/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1547/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains f0f153aeaca428139a810851f6046d1efe0b94f9 # timeout=10Checking out Revision f0f153aeaca428139a810851f6046d1efe0b94f9 (origin/pr/1547/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f f0f153aeaca428139a810851f6046d1efe0b94f9First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from cec9560 to 1cf095d Jun 24, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jun 24, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2147/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1547/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains f9803ae0687eb626fb4932cd13c45cced7f9dc6e # timeout=10Checking out Revision f9803ae0687eb626fb4932cd13c45cced7f9dc6e (origin/pr/1547/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f f9803ae0687eb626fb4932cd13c45cced7f9dc6eFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from 1cf095d to 2d01f94 Jun 26, 2017
@coveralls
Copy link

@coveralls coveralls commented Jun 26, 2017

Coverage Status

Coverage decreased (-0.2%) to 82.868% when pulling 2d01f94 on fnothaft:issues/941-autogen-projection-enums into 0306717 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2150/
Test PASSed.

@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from 2d01f94 to e5f265f Jul 11, 2017
@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Jul 11, 2017

Rebased.

Copy link
Member

@devin-petersohn devin-petersohn left a comment

Looks great!

}

private def writeHeader(fw: FileWriter, packageName: String) {
val hdr = Seq(

This comment has been minimized.

@devin-petersohn

devin-petersohn Jul 11, 2017
Member

Can this header be factored out now to a separate package object?

This comment has been minimized.

@fnothaft

fnothaft Jul 11, 2017
Author Member

Yeah, that'd be reasonable. Let me do that real quick.

@coveralls
Copy link

@coveralls coveralls commented Jul 11, 2017

Coverage Status

Coverage increased (+0.01%) to 84.033% when pulling e5f265f on fnothaft:issues/941-autogen-projection-enums into 97a8498 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2193/
Test PASSed.

Resolves #941.
@fnothaft fnothaft force-pushed the fnothaft:issues/941-autogen-projection-enums branch from e5f265f to 8221773 Jul 11, 2017
@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Jul 11, 2017

Rebased and factored out header writer. Good to go from my side.

@coveralls
Copy link

@coveralls coveralls commented Jul 11, 2017

Coverage Status

Coverage increased (+0.1%) to 84.092% when pulling 8221773 on fnothaft:issues/941-autogen-projection-enums into 467db1f on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2198/
Test PASSed.

@heuermh heuermh merged commit 324ae74 into bigdatagenomics:master Jul 11, 2017
2 of 3 checks passed
2 of 3 checks passed
codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage increased (+0.1%) to 84.092%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Jul 11, 2017

Thank you, @fnothaft

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.