New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm deployment readme #1571

Merged
merged 5 commits into from Jul 5, 2017

Conversation

Projects
5 participants
@jpdna
Member

jpdna commented Jun 19, 2017

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 19, 2017

Coverage Status

Coverage remained the same at 83.344% when pulling d9b0768 on jpdna:slurm_readme into 152a8ad on bigdatagenomics:master.

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 83.344% when pulling d9b0768 on jpdna:slurm_readme into 152a8ad on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2107/
Test PASSed.

AmplabJenkins commented Jun 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2107/
Test PASSed.

@fnothaft

Looks great! Thanks @jpdna! As an aside, would you mind folding this into 40_deploying_ADAM.md?

Show outdated Hide outdated docs/source/80_slurm.md Outdated
Show outdated Hide outdated docs/source/80_slurm.md Outdated
Show outdated Hide outdated docs/source/80_slurm.md Outdated
Show outdated Hide outdated docs/source/80_slurm.md Outdated
Show outdated Hide outdated docs/source/80_slurm.md Outdated
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 19, 2017

Member

Oh also, can you break all lines at 80 characters?

Member

fnothaft commented Jun 19, 2017

Oh also, can you break all lines at 80 characters?

@fnothaft fnothaft added this to the 0.23.0 milestone Jun 22, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 26, 2017

Coverage Status

Coverage remained the same at 83.046% when pulling 2235b65 on jpdna:slurm_readme into 0306717 on bigdatagenomics:master.

coveralls commented Jun 26, 2017

Coverage Status

Coverage remained the same at 83.046% when pulling 2235b65 on jpdna:slurm_readme into 0306717 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2153/
Test PASSed.

AmplabJenkins commented Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2153/
Test PASSed.

@fnothaft

Two small nits. Looks really good! Thanks @jpdna!

Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 26, 2017

Member

Resolves #1229.

Member

fnothaft commented Jun 26, 2017

Resolves #1229.

Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
Show outdated Hide outdated docs/source/40_deploying_ADAM.md Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 26, 2017

Coverage Status

Coverage remained the same at 83.046% when pulling 5a0e8fb on jpdna:slurm_readme into 0306717 on bigdatagenomics:master.

coveralls commented Jun 26, 2017

Coverage Status

Coverage remained the same at 83.046% when pulling 5a0e8fb on jpdna:slurm_readme into 0306717 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2158/
Test PASSed.

AmplabJenkins commented Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2158/
Test PASSed.

@heuermh

heuermh approved these changes Jul 5, 2017

@heuermh heuermh merged commit 8572fb7 into bigdatagenomics:master Jul 5, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage remained the same at 83.046%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 5, 2017

Member

Thank you, @jpdna

Member

heuermh commented Jul 5, 2017

Thank you, @jpdna

@heuermh heuermh referenced this pull request Aug 29, 2017

Closed

ADAM on Slurm/LSF #1229

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment