New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1438] Add ability to save FASTA back as a single file. #1581

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
4 participants
@fnothaft
Member

fnothaft commented Jun 26, 2017

Resolves #1438. To support saving FASTA as a single file, moved the private writeTextRdd method from the FeatureRDD to GenomicRDD, and opened protections to protected.

@fnothaft fnothaft added this to the 0.23.0 milestone Jun 26, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 26, 2017

Coverage Status

Coverage increased (+0.06%) to 83.11% when pulling 18c12e8 on fnothaft:issues/1438-as-single-fasta into 0306717 on bigdatagenomics:master.

coveralls commented Jun 26, 2017

Coverage Status

Coverage increased (+0.06%) to 83.11% when pulling 18c12e8 on fnothaft:issues/1438-as-single-fasta into 0306717 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2149/
Test PASSed.

AmplabJenkins commented Jun 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2149/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jun 26, 2017

Member

FYI, some of this was done already in #1505, which has been hanging around a while because GenomicRDD keeps changing.

Member

heuermh commented Jun 26, 2017

FYI, some of this was done already in #1505, which has been hanging around a while because GenomicRDD keeps changing.

[ADAM-1438] Add ability to save FASTA back as a single file.
Resolves #1438. To support saving FASTA as a single file, moved the
private `writeTextRdd` method from the `FeatureRDD` to `GenomicRDD`, and opened
protections to `protected`.
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 11, 2017

Member

Rebased.

Member

fnothaft commented Jul 11, 2017

Rebased.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 11, 2017

Coverage Status

Coverage increased (+0.1%) to 84.153% when pulling 2ebac20 on fnothaft:issues/1438-as-single-fasta into 97a8498 on bigdatagenomics:master.

coveralls commented Jul 11, 2017

Coverage Status

Coverage increased (+0.1%) to 84.153% when pulling 2ebac20 on fnothaft:issues/1438-as-single-fasta into 97a8498 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2194/
Test PASSed.

AmplabJenkins commented Jul 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2194/
Test PASSed.

@heuermh heuermh merged commit 467db1f into bigdatagenomics:master Jul 11, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage increased (+0.1%) to 84.153%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 11, 2017

Member

Thank you, @fnothaft

Member

heuermh commented Jul 11, 2017

Thank you, @fnothaft

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment