Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1579] Add unit test coverage for BED12 format. #1587

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 4, 2017

Resolves #1579. Found small bugs that would lead to last 6 fields not getting written if the thickStart field wasn't written. Also, identified a bug where the strand would be set to unknown if an independent strand was provided.

Resolves #1579. Found small bugs that would lead to last 6 fields not getting
written if the thickStart field wasn't written. Also, identified a bug where the
strand would be set to unknown if an independent strand was provided.
@fnothaft fnothaft requested a review from heuermh Jul 4, 2017
@coveralls
Copy link

@coveralls coveralls commented Jul 4, 2017

Coverage Status

Coverage decreased (-0.3%) to 82.744% when pulling ee331a2 on fnothaft:issues/1579-bed12-unittest into 0306717 on bigdatagenomics:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 4, 2017

Coverage Status

Coverage increased (+0.2%) to 83.267% when pulling ee331a2 on fnothaft:issues/1579-bed12-unittest into 0306717 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2174/
Test PASSed.

@heuermh
heuermh approved these changes Jul 5, 2017
Copy link
Member

@heuermh heuermh left a comment

Good catch!

@heuermh heuermh merged commit 9ff0387 into bigdatagenomics:master Jul 5, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage increased (+0.2%) to 83.267%
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Jul 5, 2017

Thank you, @fnothaft

@fnothaft fnothaft deleted the fnothaft:issues/1579-bed12-unittest branch Jul 5, 2017
@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.