New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1490] Add asSingleFile to saveAsFastq and related. #1621

Merged
merged 2 commits into from Jul 22, 2017

Conversation

Projects
4 participants
@heuermh
Member

heuermh commented Jul 21, 2017

Fixes #1490

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 21, 2017

Coverage Status

Coverage increased (+0.5%) to 84.755% when pulling 8e4fee8 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

coveralls commented Jul 21, 2017

Coverage Status

Coverage increased (+0.5%) to 84.755% when pulling 8e4fee8 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2263/
Test PASSed.

AmplabJenkins commented Jul 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2263/
Test PASSed.

@fnothaft

LGTM but can you plumb this through to maybeSaveFastq as well?

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2017

Coverage Status

Coverage decreased (-0.3%) to 83.961% when pulling fb87980 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

coveralls commented Jul 22, 2017

Coverage Status

Coverage decreased (-0.3%) to 83.961% when pulling fb87980 on heuermh:single-file-save into 640c44b on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 22, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2272/
Test PASSed.

AmplabJenkins commented Jul 22, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2272/
Test PASSed.

@fnothaft fnothaft merged commit d9b531c into bigdatagenomics:master Jul 22, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage decreased (-0.3%) to 83.961%
Details
default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 22, 2017

Member

Merged! Thanks @heuermh!

Member

fnothaft commented Jul 22, 2017

Merged! Thanks @heuermh!

@heuermh heuermh deleted the heuermh:single-file-save branch Jul 22, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment