New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1607] Update distribution assembly task to attach assembly überjar #1622

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
4 participants
@fnothaft
Member

fnothaft commented Jul 22, 2017

Resolves #1607. 3ea4f18 renamed the überjar generated by the adam-assembly package from adam_<version>.jar to adam-assembly_<version>.jar, but did not update the distribution assembly task. This commit updates that task, and adds code to jenkins-test to ensure that the assembly jar is packaged in the distribution.

@fnothaft fnothaft added this to the 0.23.0 milestone Jul 22, 2017

@fnothaft fnothaft requested a review from heuermh Jul 22, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2017

Coverage Status

Coverage remained the same at 83.874% when pulling 49055ad on fnothaft:issues/1607-assembly-jar-distribution into 6abe7a6 on bigdatagenomics:master.

coveralls commented Jul 22, 2017

Coverage Status

Coverage remained the same at 83.874% when pulling 49055ad on fnothaft:issues/1607-assembly-jar-distribution into 6abe7a6 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 22, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2270/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1622/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains ddc68d1a4c52e541001199d7a224d99a8324c50d # timeout=10Checking out Revision ddc68d1a4c52e541001199d7a224d99a8324c50d (origin/pr/1622/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f ddc68d1a4c52e541001199d7a224d99a8324c50dFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,2.1.0,centosTriggering ADAM-prb ? 2.3.0,2.11,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,2.1.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

AmplabJenkins commented Jul 22, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2270/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1622/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains ddc68d1a4c52e541001199d7a224d99a8324c50d # timeout=10Checking out Revision ddc68d1a4c52e541001199d7a224d99a8324c50d (origin/pr/1622/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f ddc68d1a4c52e541001199d7a224d99a8324c50dFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.10,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,2.1.0,centosTriggering ADAM-prb ? 2.3.0,2.11,2.1.0,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.10,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.6.0,2.11,2.1.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.1.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result SUCCESSADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result SUCCESSNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

[ADAM-1607] Update distribution assembly task to attach assembly über…
…jar.

Resolves #1607. 3ea4f18 renamed the überjar
generated by the adam-assembly package from `adam_<version>.jar` to
`adam-assembly_<version>.jar`, but did not update the distribution
assembly task. This commit updates that task, and adds code to `jenkins-test`
to ensure that the assembly jar is packaged in the distribution.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2017

Coverage Status

Coverage remained the same at 83.874% when pulling fdc4b40 on fnothaft:issues/1607-assembly-jar-distribution into 6abe7a6 on bigdatagenomics:master.

coveralls commented Jul 22, 2017

Coverage Status

Coverage remained the same at 83.874% when pulling fdc4b40 on fnothaft:issues/1607-assembly-jar-distribution into 6abe7a6 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 22, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2271/
Test PASSed.

AmplabJenkins commented Jul 22, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2271/
Test PASSed.

@heuermh heuermh merged commit 16e2afb into bigdatagenomics:master Jul 22, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage remained the same at 83.874%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 22, 2017

Member

Thank you, @fnothaft! Thank you @pbashyal-nmdp for reporting this issue.

Member

heuermh commented Jul 22, 2017

Thank you, @fnothaft! Thank you @pbashyal-nmdp for reporting this issue.

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment