New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1615] Add transform and transmute APIs to Java, R, and Python #1627

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
5 participants
@fnothaft
Member

fnothaft commented Jul 24, 2017

Resolves #1615. Adds GenomicDatasetConversion class to adam-core API, along with accompanying implementations in org.bdgenomics.adam.api.java package. Adds transformDataFrame and transmuteDataFrame to GenomicRDD API. To enable use from Python and R, we provide a DataFrameConversionWrapper that wraps the product of an R/Python function in a Spark Java API Function.

  • When this moves on top of #1628, need to make sure the functions move on top of GenomicDataset.

@fnothaft fnothaft added this to the 0.23.0 milestone Jul 24, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-0.5%) to 83.464% when pulling b5b9a5f on fnothaft:issues/1615-transform-transmute-java-r-python into 9bc5e15 on bigdatagenomics:master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.5%) to 83.464% when pulling b5b9a5f on fnothaft:issues/1615-transform-transmute-java-r-python into 9bc5e15 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2276/
Test PASSed.

AmplabJenkins commented Jul 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2276/
Test PASSed.

@devin-petersohn

Looks good!

@heuermh

Will review again after rebase

dfFn = self._wrapTransformation(tFn)
# if no conversion function is provided, try to infer
if convFn is None:

This comment has been minimized.

@heuermh

heuermh Jul 25, 2017

Member

This method name stuff is brittle, but I can't see any other way to do it

@heuermh

heuermh Jul 25, 2017

Member

This method name stuff is brittle, but I can't see any other way to do it

fnothaft added some commits Jul 21, 2017

[ADAM-1615] Add transform and transmute APIs to Java, R, and Python
Resolves #1615. Adds `GenomicDatasetConversion` class to adam-core API, along
with accompanying implementations in `org.bdgenomics.adam.api.java` package.
Adds `transformDataFrame` and `transmuteDataFrame` to `GenomicRDD` API. To
enable use from Python and R, we provide a `DataFrameConversionWrapper` that
wraps the product of an R/Python function in a Spark Java API `Function`.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 2, 2017

Coverage Status

Coverage decreased (-0.5%) to 83.464% when pulling 6778abd on fnothaft:issues/1615-transform-transmute-java-r-python into 9032698 on bigdatagenomics:master.

coveralls commented Aug 2, 2017

Coverage Status

Coverage decreased (-0.5%) to 83.464% when pulling 6778abd on fnothaft:issues/1615-transform-transmute-java-r-python into 9032698 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 2, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2310/
Test PASSed.

AmplabJenkins commented Aug 2, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2310/
Test PASSed.

@heuermh heuermh merged commit ca3c587 into bigdatagenomics:master Aug 2, 2017

2 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
coverage/coveralls Coverage decreased (-0.5%) to 83.464%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 2, 2017

Member

Thank you, @fnothaft!

Member

heuermh commented Aug 2, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment