Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithms docs formatting #1645

Closed
wants to merge 4 commits into from
Closed

Conversation

@gunjanbaid
Copy link
Contributor

@gunjanbaid gunjanbaid commented Jul 27, 2017

See #1639 for discussion.

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 83.961% when pulling fd214c0 on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 27, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2290/
Test PASSed.

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 83.961% when pulling 9a34773 on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 27, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2291/
Test PASSed.

Copy link
Member

@fnothaft fnothaft left a comment

LGTM, but why are we dropping the anchors here?

@gunjanbaid
Copy link
Contributor Author

@gunjanbaid gunjanbaid commented Jul 27, 2017

Added anchor tags back based on related discussion in #1642

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 83.961% when pulling b54511b on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 27, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2299/
Test PASSed.

@heuermh
heuermh approved these changes Aug 2, 2017
Copy link
Member

@fnothaft fnothaft left a comment

No specific changes to request, but this breaks the pandoc generated PDF. Let's hold off on this until we move to reStructuredText.

@gunjanbaid
Copy link
Contributor Author

@gunjanbaid gunjanbaid commented Aug 2, 2017

Sounds good.

@heuermh
Copy link
Member

@heuermh heuermh commented Dec 13, 2017

I believe these fixes were included in #1646. Please reopen if anything was missed.

@heuermh heuermh closed this Dec 13, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.