New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1663] Enable read groups with repeated names when unioning. #1665

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
4 participants
@fnothaft
Member

fnothaft commented Aug 11, 2017

Resolves #1663. When unioning two read groups together, calls distinct after appending the two RecordGroupDictionaries.

[ADAM-1663] Enable read groups with repeated names when unioning.
Resolves #1663. When unioning two read groups together, calls distinct after
appending the two RecordGroupDictionaries.

@fnothaft fnothaft added this to the 0.23.0 milestone Aug 11, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 11, 2017

Coverage Status

Coverage increased (+0.01%) to 83.454% when pulling 2492786 on fnothaft:issues/1663-glob-read-groups into 50d29af on bigdatagenomics:master.

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.01%) to 83.454% when pulling 2492786 on fnothaft:issues/1663-glob-read-groups into 50d29af on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2317/
Test PASSed.

AmplabJenkins commented Aug 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2317/
Test PASSed.

@heuermh heuermh merged commit 6c8f8d7 into bigdatagenomics:master Aug 15, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage increased (+0.01%) to 83.454%
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 15, 2017

Member

Thank you, @fnothaft!

Member

heuermh commented Aug 15, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment