New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API fixes for AlignmentRecordRDD #1675

Merged
merged 2 commits into from Aug 22, 2017

Conversation

Projects
5 participants
@akmorrow13
Contributor

akmorrow13 commented Aug 21, 2017

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 21, 2017

Coverage Status

Coverage decreased (-0.4%) to 82.957% when pulling 6f968c2 on akmorrow13:python into b46b583 on bigdatagenomics:master.

coveralls commented Aug 21, 2017

Coverage Status

Coverage decreased (-0.4%) to 82.957% when pulling 6f968c2 on akmorrow13:python into b46b583 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 21, 2017

Coverage Status

Coverage remained the same at 83.403% when pulling 6f968c2 on akmorrow13:python into b46b583 on bigdatagenomics:master.

coveralls commented Aug 21, 2017

Coverage Status

Coverage remained the same at 83.403% when pulling 6f968c2 on akmorrow13:python into b46b583 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2321/
Test PASSed.

AmplabJenkins commented Aug 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2321/
Test PASSed.

@@ -30,14 +30,14 @@ else
ASSEMBLY_DIR="$SCRIPT_DIR/adam-assembly/target"
fi
num_jars="$(ls -1 "$ASSEMBLY_DIR" | grep "^adam[0-9A-Za-z\.\_\-]*\.jar$" | grep -v javadoc | grep -v sources | wc -l)"
num_jars="$(ls -1 "$ASSEMBLY_DIR" | grep "^adam-assembly_[0-9A-Za-z\.-]*\.jar$" | grep -v javadoc | grep -v sources | wc -l)"

This comment has been minimized.

@heuermh

heuermh Aug 22, 2017

Member

This was fixed a different way in #1651, by delegating to a new find-adam-assembly.sh script. I suppose that doesn't matter if this PR is merged first.

@heuermh

heuermh Aug 22, 2017

Member

This was fixed a different way in #1651, by delegating to a new find-adam-assembly.sh script. I suppose that doesn't matter if this PR is merged first.

This comment has been minimized.

@fnothaft

fnothaft Aug 22, 2017

Member

6 of one, half dozen of the other to me.

@fnothaft

fnothaft Aug 22, 2017

Member

6 of one, half dozen of the other to me.

@fnothaft fnothaft merged commit 9b51df5 into bigdatagenomics:master Aug 22, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage remained the same at 83.403%
Details
default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 22, 2017

Member

Merged! Thanks @akmorrow13!

Member

fnothaft commented Aug 22, 2017

Merged! Thanks @akmorrow13!

@heuermh heuermh added this to the 0.23.0 milestone Aug 22, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment