Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1694] Add short readable descriptions for toString in subclasses of GenomicRDD. #1698

Merged
merged 1 commit into from Sep 6, 2017

Conversation

@heuermh
Copy link
Member

@heuermh heuermh commented Aug 29, 2017

Fixes #1694

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Aug 29, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2339/
Test PASSed.

@coveralls
Copy link

@coveralls coveralls commented Aug 29, 2017

Coverage Status

Coverage increased (+0.09%) to 83.519% when pulling 6ba1351 on heuermh:genomicrdd-tostring into 12c56fd on bigdatagenomics:master.

Copy link
Member

@fnothaft fnothaft left a comment

General approach looks good, but can't we move this all into the GenomicRDD trait?

@@ -490,4 +490,7 @@ sealed abstract class NucleotideContigFragmentRDD extends AvroGenomicRDD[Nucleot
(p._1, p._2: java.lang.Long)
}).toJavaRDD()
}

override def toString = "%s with %d reference sequences"

This comment has been minimized.

@fnothaft

fnothaft Aug 30, 2017
Member

You should be able to factor this into the GenomicRDD trait, no?

This comment has been minimized.

@heuermh

heuermh Aug 30, 2017
Author Member

I think it is possible ... but I read some odd things about toString on traits and figured the sealed abstract classes would be the best place. Then the messages are slightly different so it isn't exactly breaking DRY.

This comment has been minimized.

@fnothaft

fnothaft Sep 2, 2017
Member

What odd things did you see?

@heuermh heuermh modified the milestone: 0.23.0 Sep 1, 2017
@heuermh heuermh force-pushed the heuermh:genomicrdd-tostring branch from 6ba1351 to 5078c07 Sep 5, 2017
@coveralls
Copy link

@coveralls coveralls commented Sep 5, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.472% when pulling 5078c07 on heuermh:genomicrdd-tostring into 511f925 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Sep 5, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2350/
Test PASSed.

@fnothaft fnothaft merged commit 51efbaf into bigdatagenomics:master Sep 6, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
coverage/coveralls Coverage decreased (-0.1%) to 83.472%
Details
default Merged build finished.
Details
@fnothaft
Copy link
Member

@fnothaft fnothaft commented Sep 6, 2017

Merged! Thanks @heuermh!

@heuermh heuermh deleted the heuermh:genomicrdd-tostring branch Sep 6, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.