New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making join return types consistent #1737

Merged
merged 2 commits into from Sep 25, 2017

Conversation

Projects
4 participants
@devin-petersohn
Member

devin-petersohn commented Sep 18, 2017

Resolves #1734

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 18, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2386/
Test PASSed.

AmplabJenkins commented Sep 18, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2386/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 19, 2017

Member

LGTM! Thanks @devin-petersohn! I'll leave this open for a day as well, in case @heuermh would like to review.

Member

fnothaft commented Sep 19, 2017

LGTM! Thanks @devin-petersohn! I'll leave this open for a day as well, in case @heuermh would like to review.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Sep 19, 2017

Member

Please wait to merge until I update pull request.

Member

devin-petersohn commented Sep 19, 2017

Please wait to merge until I update pull request.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Sep 19, 2017

Member

Ready for review. Sorry for forgetting to delete the Z type.

Member

devin-petersohn commented Sep 19, 2017

Ready for review. Sorry for forgetting to delete the Z type.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2388/
Test PASSed.

AmplabJenkins commented Sep 19, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2388/
Test PASSed.

@heuermh heuermh merged commit 06cd226 into bigdatagenomics:master Sep 25, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh
Member

heuermh commented Sep 25, 2017

Thank you, @devin-petersohn

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment