New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled thresholding for joins and standardized regionFn #1741

Merged
merged 4 commits into from Oct 4, 2017

Conversation

Projects
4 participants
@devin-petersohn
Member

devin-petersohn commented Sep 21, 2017

Resolves #1739, #1740.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2390/
Test PASSed.

AmplabJenkins commented Sep 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2390/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2391/
Test PASSed.

AmplabJenkins commented Sep 21, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2391/
Test PASSed.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Sep 25, 2017

Member

Rebased on current master and overloaded methods with optionals. I haven't changed the threshold name yet. I want to make sure it passes with @AmplabJenkins first.

Member

devin-petersohn commented Sep 25, 2017

Rebased on current master and overloaded methods with optionals. I haven't changed the threshold name yet. I want to make sure it passes with @AmplabJenkins first.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 25, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2394/
Test PASSed.

AmplabJenkins commented Sep 25, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2394/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2395/
Test PASSed.

AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2395/
Test PASSed.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Sep 26, 2017

Member

Rebased and made changes to architecture reflecting this comment.

Member

devin-petersohn commented Sep 26, 2017

Rebased and made changes to architecture reflecting this comment.

devin-petersohn added a commit to devin-petersohn/adam that referenced this pull request Sep 26, 2017

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2397/
Test PASSed.

AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2397/
Test PASSed.

@heuermh

heuermh approved these changes Oct 4, 2017

@heuermh heuermh merged commit 77a16f2 into bigdatagenomics:master Oct 4, 2017

1 of 2 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 4, 2017

Member

Squashed and merged as commit 77a16f2. Thank you, @devin-petersohn

Member

heuermh commented Oct 4, 2017

Squashed and merged as commit 77a16f2. Thank you, @devin-petersohn

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment