New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1745] Adding LeftOuterShuffleRegionJoinAndGroupByLeft and tests #1746

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
4 participants
@devin-petersohn
Member

devin-petersohn commented Sep 26, 2017

Resolves #1745. Depends on #1741 .

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2396/
Test PASSed.

AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2396/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2398/
Test PASSed.

AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2398/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 4, 2017

Member

I squashed and merged #1741, which hopefully was the right thing to do. You'll need to rebase and squash here.

Member

heuermh commented Oct 4, 2017

I squashed and merged #1741, which hopefully was the right thing to do. You'll need to rebase and squash here.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 4, 2017

Member

Couple of docs changes, but otherwise LGTM

Member

fnothaft commented Oct 4, 2017

Couple of docs changes, but otherwise LGTM

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Oct 4, 2017

Member

Resolved docs issues and rebased.

Member

devin-petersohn commented Oct 4, 2017

Resolved docs issues and rebased.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2408/
Test PASSed.

AmplabJenkins commented Oct 4, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2408/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 4, 2017

Member

LGTM, @heuermh please review and merge if OK on your end.

Member

fnothaft commented Oct 4, 2017

LGTM, @heuermh please review and merge if OK on your end.

@heuermh

heuermh approved these changes Oct 4, 2017

Looks great!

@heuermh heuermh merged commit 45b9fe8 into bigdatagenomics:master Oct 4, 2017

1 of 2 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 4, 2017

Member

Thank you, @devin-petersohn!

Member

heuermh commented Oct 4, 2017

Thank you, @devin-petersohn!

@heuermh heuermh changed the title from Issue#1745 left outer group by left to [ADAM-1745] Adding LeftOuterShuffleRegionJoinAndGroupByLeft and tests Oct 4, 2017

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment