Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1747] Fixed subtract bug and tests #1748

Merged

Conversation

@devin-petersohn
Copy link
Member

@devin-petersohn devin-petersohn commented Sep 26, 2017

Resolves #1747.

@devin-petersohn
Copy link
Member Author

@devin-petersohn devin-petersohn commented Sep 26, 2017

I remember the logic getting confusing when I first wrote this, but somehow even the tests were wrong.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2399/
Test PASSed.

@heuermh heuermh changed the title Fixed subtract bug and tests [ADAM-1747] Fixed subtract bug and tests Sep 27, 2017
@heuermh heuermh merged commit 9bc5aad into bigdatagenomics:master Sep 27, 2017
2 checks passed
2 checks passed
codacy/pr Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Sep 27, 2017

Thank you, @devin-petersohn

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.