New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1747] Fixed subtract bug and tests #1748

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
3 participants
@devin-petersohn
Member

devin-petersohn commented Sep 26, 2017

Resolves #1747.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Sep 26, 2017

Member

I remember the logic getting confusing when I first wrote this, but somehow even the tests were wrong.

Member

devin-petersohn commented Sep 26, 2017

I remember the logic getting confusing when I first wrote this, but somehow even the tests were wrong.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2399/
Test PASSed.

AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2399/
Test PASSed.

@heuermh heuermh changed the title from Fixed subtract bug and tests to [ADAM-1747] Fixed subtract bug and tests Sep 27, 2017

@heuermh heuermh merged commit 9bc5aad into bigdatagenomics:master Sep 27, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh
Member

heuermh commented Sep 27, 2017

Thank you, @devin-petersohn

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment