Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to _replaceRdd with tests #1749

Merged
merged 1 commit into from Sep 27, 2017
Merged

Conversation

@akmorrow13
Copy link
Contributor

@akmorrow13 akmorrow13 commented Sep 26, 2017

No description provided.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Sep 26, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2400/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1749/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0 # timeout=10Checking out Revision 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0 (origin/pr/1749/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 3e638b5b1b55dfaa8062aad2e879745f06f1e1b0First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.2,2.11,1.6.3,centosTriggering ADAM-prb ? 2.7.3,2.11,1.6.3,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.0,centosTriggering ADAM-prb ? 2.7.3,2.10,1.6.3,centosTriggering ADAM-prb ? 2.6.2,2.10,1.6.3,centosTriggering ADAM-prb ? 2.6.2,2.10,2.2.0,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.0,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.0,centosADAM-prb ? 2.6.2,2.11,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.0,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,1.6.3,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.10,1.6.3,centos completed with result FAILUREADAM-prb ? 2.6.2,2.10,2.2.0,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.10,2.2.0,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2401/
Test PASSed.

@akmorrow13 akmorrow13 force-pushed the akmorrow13:python-fixes branch from 27c9a1a to eec00a5 Sep 26, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Sep 26, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2402/
Test PASSed.

@@ -692,6 +692,11 @@ def _inferConversionFn(self, destClass):
class FeatureRDD(GenomicDataset):


def _replaceRdd(self, newRdd):

This comment has been minimized.

@heuermh

heuermh Sep 27, 2017
Member

Is this only necessary in class FeatureRDD?

This comment has been minimized.

@akmorrow13

akmorrow13 Sep 27, 2017
Author Contributor

@heuermh if it is not present transform will fail (_replaceRdd is not a function)

This comment has been minimized.

@akmorrow13

akmorrow13 Sep 27, 2017
Author Contributor

https://github.com/akmorrow13/adam/blob/eec00a545dca3e4cd4e258023c99a1afa8a8974e/adam-python/bdgenomics/adam/rdd.py#L104 is defined in GenomicRDD, calling _replaceRDD, which FeatureRDD does not have

This comment has been minimized.

@heuermh

heuermh Sep 27, 2017
Member

Thanks!

@@ -692,6 +692,11 @@ def _inferConversionFn(self, destClass):
class FeatureRDD(GenomicDataset):


def _replaceRdd(self, newRdd):

This comment has been minimized.

@heuermh

heuermh Sep 27, 2017
Member

Thanks!

@heuermh heuermh merged commit b2c243f into bigdatagenomics:master Sep 27, 2017
2 checks passed
2 checks passed
codacy/pr Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Sep 27, 2017

Thank you, @akmorrow13

@heuermh heuermh added this to the 0.23.0 milestone Oct 4, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.