New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1813] Delegate right outer shuffle region join to left OSRJ implementation. #1814

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
3 participants
@fnothaft
Member

fnothaft commented Dec 1, 2017

Resolves #1813. Left and right outer joins are symmetric: that is to say, a right outer join is can be rewritten as a left outer join by swapping the two input tables, and by modifying the layout of the output. To resolve the mismatch between the left and right outer joins, this PR deletes the right outer join implementation and delegates back to the left outer join + tuple order swap.

[ADAM-1813] Delegate right outer shuffle region join to left OSRJ imp…
…lementation.

Left and right outer joins are symmetric: that is to say, a right outer join is
can be rewritten as a left outer join by swapping the two input tables, and by
modifying the layout of the output. To resolve the mismatch between the left and
right outer joins, this PR deletes the right outer join implementation and
delegates back to the left outer join + tuple order swap. Resolves #1813.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 1, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2492/
Test PASSed.

AmplabJenkins commented Dec 1, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2492/
Test PASSed.

@heuermh

heuermh approved these changes Dec 1, 2017

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 1, 2017

Member

@heuermh hold on merging this, I'm waiting for validation from someone.

Member

fnothaft commented Dec 1, 2017

@heuermh hold on merging this, I'm waiting for validation from someone.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 1, 2017

Member

This is good to merge!

Member

fnothaft commented Dec 1, 2017

This is good to merge!

@heuermh heuermh merged commit 573e544 into bigdatagenomics:master Dec 1, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details

@heuermh heuermh added this to the 0.23.0 milestone Dec 1, 2017

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Dec 1, 2017

Member

Sweet. Thank you, @fnothaft!

Member

heuermh commented Dec 1, 2017

Sweet. Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment