Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1822] Misc docs cleanup #1827

Merged
merged 7 commits into from Dec 13, 2017
Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Dec 11, 2017

WIP

@fnothaft fnothaft added this to the 0.23.0 milestone Dec 11, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Dec 11, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2506/
Test PASSed.

@heuermh
Copy link
Member

@heuermh heuermh commented Dec 12, 2017

Do you know how to fix these errors in math formatting?

\#errors(cov)+1
---
\#observations(cov)+2

and

trimSecond <- $allButFirst($second$)
@heuermh
Copy link
Member

@heuermh heuermh commented Dec 12, 2017

Created pull request fnothaft#23 against your branch.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Dec 12, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2509/
Test PASSed.

@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Dec 12, 2017

Thanks for the ping on those last two @heuermh; I've pushed two commits that address them. Is this ready to merge from your end?

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Dec 12, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2510/
Test PASSed.

@heuermh
Copy link
Member

@heuermh heuermh commented Dec 12, 2017

Yes, LGTM. Let me know if the commits are how you'd like them. I'll merge later this morning.

@heuermh heuermh changed the title Misc docs cleanup [ADAM-1822] Misc docs cleanup Dec 12, 2017
@heuermh
Copy link
Member

@heuermh heuermh commented Dec 12, 2017

Fixes #1822

@heuermh heuermh merged commit d213820 into bigdatagenomics:master Dec 13, 2017
2 checks passed
2 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Dec 13, 2017

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.