Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Coverage python API and adds tests #1870

Merged
merged 2 commits into from Jan 11, 2018

Conversation

@akmorrow13
Copy link
Contributor

@akmorrow13 akmorrow13 commented Jan 11, 2018

No description provided.

@akmorrow13 akmorrow13 changed the title Coverage python Fixes Coverage python API and adds tests Jan 11, 2018
@coveralls
Copy link

@coveralls coveralls commented Jan 11, 2018

Coverage Status

Coverage remained the same at 82.821% when pulling b69c4ec on akmorrow13:coverage-python into 71f9d13 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jan 11, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2561/
Test PASSed.

Copy link
Member

@fnothaft fnothaft left a comment

LGTM @akmorrow13! Is this good to go on your end?

@akmorrow13 akmorrow13 force-pushed the akmorrow13:coverage-python branch from b69c4ec to ea785cd Jan 11, 2018
@akmorrow13
Copy link
Contributor Author

@akmorrow13 akmorrow13 commented Jan 11, 2018

yep @fnothaft this is good on my end!

@coveralls
Copy link

@coveralls coveralls commented Jan 11, 2018

Coverage Status

Coverage remained the same at 82.778% when pulling ea785cd on akmorrow13:coverage-python into 9de489b on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jan 11, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2563/
Test PASSed.

@fnothaft fnothaft merged commit 9adadef into bigdatagenomics:master Jan 11, 2018
1 of 2 checks passed
1 of 2 checks passed
Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
default Merged build finished.
Details
@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jan 11, 2018

Merged! Thanks @akmorrow13!

@heuermh heuermh added this to the 0.24.0 milestone Jan 24, 2018
@heuermh heuermh added this to Completed in Release 0.24.0 Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants