Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1874] Dedupe samples when loading VCFs. #1876

Merged
merged 1 commit into from Jan 22, 2018

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jan 16, 2018

Resolves #1874. While samples should be unique in a single VCF, we may load data from multiple VCFs that contain the same samples (e.g., VCFs from a single sequencing project where the VCFs are split by chromosome). This change dedupes sample IDs on load.

Resolves #1874. While samples should be unique in a single VCF, we may load data
from multiple VCFs that contain the same samples (e.g., VCFs from a single
sequencing project where the VCFs are split by chromosome). This change dedupes
sample IDs on load.
@fnothaft fnothaft added this to the 0.24.0 milestone Jan 16, 2018
@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Jan 21, 2018

Jenkins, test this please.

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2018

Coverage Status

Coverage increased (+0.1%) to 82.94% when pulling 1e5450c on fnothaft:issues/1874-dedupe-samples into 4223f56 on bigdatagenomics:master.

3 similar comments
@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2018

Coverage Status

Coverage increased (+0.1%) to 82.94% when pulling 1e5450c on fnothaft:issues/1874-dedupe-samples into 4223f56 on bigdatagenomics:master.

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2018

Coverage Status

Coverage increased (+0.1%) to 82.94% when pulling 1e5450c on fnothaft:issues/1874-dedupe-samples into 4223f56 on bigdatagenomics:master.

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2018

Coverage Status

Coverage increased (+0.1%) to 82.94% when pulling 1e5450c on fnothaft:issues/1874-dedupe-samples into 4223f56 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jan 21, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2582/
Test PASSed.

@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Jan 22, 2018

Ping @heuermh for review/merge.

@heuermh heuermh merged commit 87c515b into bigdatagenomics:master Jan 22, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Jan 22, 2018

Thank you, @fnothaft!

@heuermh heuermh added this to Completed in Release 0.24.0 Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants